Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(automation): add link checking #728

Merged
merged 94 commits into from
Oct 12, 2021
Merged

ci(automation): add link checking #728

merged 94 commits into from
Oct 12, 2021

Conversation

bnb
Copy link
Member

@bnb bnb commented Mar 11, 2021

At the request of @jorydotcom, adds a CI job that will run on pushes, on a few PR events, and when manually triggered via the GitHub Actions UI.

Historically, in Node.js there's been a non-trivial amount of link rot. This should help us identify dead links and where links will break when we're making changes.

@bnb
Copy link
Member Author

bnb commented Mar 11, 2021

38 broken links 🥴

@bnb
Copy link
Member Author

bnb commented Mar 11, 2021

Looks like the Dojo reporting form is broken (410'ing):

* Dojo - [reporting form](https://docs.google.com/forms/d/1ZiCUv3FsarWetoQ8J5QnCdIrHLj0xMmwNSLCyBkio7c/viewform?edit_requested=true)

@sendilkumarn
Copy link
Member

This is super cool. Yeah most of them were in meeting notes.

@dylans
Copy link
Contributor

dylans commented Mar 12, 2021

Looks like the Dojo reporting form is broken (410'ing):

* Dojo - [reporting form](https://docs.google.com/forms/d/1ZiCUv3FsarWetoQ8J5QnCdIrHLj0xMmwNSLCyBkio7c/viewform?edit_requested=true)

Looks like this was accidentally removed when Dojo switched to having its own Google account for email/docs/etc. I don't seem to be able to find what was on the form previously, so if you could nudge me with what other projects have for this, I can recreate it pretty quickly. Thanks!

@bnb
Copy link
Member Author

bnb commented Mar 12, 2021

@dylans I've got no idea on what the form was, perhaps @jorydotcom has an idea 😅

@jorydotcom
Copy link
Contributor

@bnb I'll follow up with @dylans via email 😄

@bnb
Copy link
Member Author

bnb commented Mar 12, 2021

Added do not merge label until I'm done fixing the errors 👍🏻

PROJECT_CHARTER_TEMPLATE.md Outdated Show resolved Hide resolved
@bnb
Copy link
Member Author

bnb commented Sep 28, 2021

(I assume we'll just squash merge this when it's time, sorry for the noise)

@bnb bnb removed the do not merge label Sep 28, 2021
@bnb
Copy link
Member Author

bnb commented Sep 28, 2021

this can be merged now :)

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if still green

Copy link
Member

@joesepi joesepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the one change

@bnb bnb merged commit 4201e8a into main Oct 12, 2021
@bnb bnb deleted the bnb/add-link-checking branch October 12, 2021 18:43
tobie pushed a commit that referenced this pull request Sep 1, 2023
* ci(automation): add dead link checking

* fix: add private repo to skip list

* fix: unbreak Contributor Covenant link

* fix: old meeting deep link

* fix: broken proposal links

* fix: update broken links to PROJECT_PROGRESSION

* fix: update broken link to EXPECTATIONS

* fix: updated broken links to INDVIDIUAL_MEMBERSHIP

* fix: remove broken link to repo that doesn't exist

* fix: update broken link to CPC charter proposal

* fix: update link to FOUNDATION_CODE_OF_CONDUCT_REQUIREMENTS.md

* fix: make a markdown link work by using correct syntax

* fix: update AJV contributing link

* fix: add space to unbreak links

* chore: remove link to broken/removed PR in the Node.js org

* chore: update broken links that have transitioned to openjs-foundation from nodejs

* fix: update k8s links

* fix: update link to use correct branch/filename

* chore: remove broken link to ancient Project Progression proposal

* fix: update old broken link to Community Board Representation proposal

* fix: use HEAD rather than master

* Revert "fix: update link to use correct branch/filename"

This reverts commit f167243.

* chore: use `HEAD` instead of `master`

Co-authored-by: Jordan Harband <ljharb@gmail.com>

* fix: update old link to repo that doesn't exist to working link

* chore: reflect change from "staging process" to "proposal process"

* fix: use permanent link to Node.js contributing file

* re-add broken link

Co-authored-by: Jordan Harband <ljharb@gmail.com>

* fix broken link

Co-authored-by: Jordan Harband <ljharb@gmail.com>

* fix broken link

Co-authored-by: Jordan Harband <ljharb@gmail.com>

* fix broken link

Co-authored-by: Jordan Harband <ljharb@gmail.com>

* fix broken link

Co-authored-by: Jordan Harband <ljharb@gmail.com>

* add missing trailing newline

* chore: main > head

Co-authored-by: Jordan Harband <ljharb@gmail.com>

* chore: main > head

Co-authored-by: Jordan Harband <ljharb@gmail.com>

* chore: fix missing broken link

* docs: remove reference to non-existent document

* docs: link fixes

* doc: fix AMP contributing link

* docs: link fixes in proposals readmes

* docs: more link changes

* docs: fix old broken github link

* Globally replace all /master/ and /main/ to /HEAD/

* Travel fund request: Unicode Conference, 13-16 October (#800)

* chore: Rename TRAVEL_FUND/2020.md -> TRAVEL_FUND/2021.md

* Add travel fund request for Unicode Conference

* Update Dojo CoC (#799)

Leverage the OpenJSF reporting email address rather than a dead Google form.

* ci(automation): add dead link checking

* fix: add private repo to skip list

* fix: unbreak Contributor Covenant link

* fix: old meeting deep link

* fix: broken proposal links

* fix: update broken links to PROJECT_PROGRESSION

* fix: update broken link to EXPECTATIONS

* fix: updated broken links to INDVIDIUAL_MEMBERSHIP

* fix: remove broken link to repo that doesn't exist

* fix: update broken link to CPC charter proposal

* fix: update link to FOUNDATION_CODE_OF_CONDUCT_REQUIREMENTS.md

* fix: make a markdown link work by using correct syntax

* fix: update AJV contributing link

* fix: add space to unbreak links

* chore: remove link to broken/removed PR in the Node.js org

* chore: update broken links that have transitioned to openjs-foundation from nodejs

* fix: update k8s links

* fix: update link to use correct branch/filename

* chore: remove broken link to ancient Project Progression proposal

* fix: update old broken link to Community Board Representation proposal

* fix: use HEAD rather than master

* Revert "fix: update link to use correct branch/filename"

This reverts commit f167243.

* chore: use `HEAD` instead of `master`

Co-authored-by: Jordan Harband <ljharb@gmail.com>

* fix: update old link to repo that doesn't exist to working link

* chore: reflect change from "staging process" to "proposal process"

* fix: use permanent link to Node.js contributing file

* re-add broken link

Co-authored-by: Jordan Harband <ljharb@gmail.com>

* fix broken link

Co-authored-by: Jordan Harband <ljharb@gmail.com>

* fix broken link

Co-authored-by: Jordan Harband <ljharb@gmail.com>

* fix broken link

Co-authored-by: Jordan Harband <ljharb@gmail.com>

* fix broken link

Co-authored-by: Jordan Harband <ljharb@gmail.com>

* add missing trailing newline

* chore: main > head

Co-authored-by: Jordan Harband <ljharb@gmail.com>

* chore: main > head

Co-authored-by: Jordan Harband <ljharb@gmail.com>

* chore: fix missing broken link

* docs: remove reference to non-existent document

* docs: link fixes

* doc: fix AMP contributing link

* docs: link fixes in proposals readmes

* docs: more link changes

* docs: fix old broken github link

* Globally replace all /master/ and /main/ to /HEAD/

* doc: update alternate process

* doc: remove dead link from old CPC charter doc

* doc: remove unnecessary link that doesn't work

* ci: rename to link-checker

* fixup

Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
Co-authored-by: Dylan Schiemann <dylan@dojotoolkit.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants