Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] add proposal about resize asts pvc #1651

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

ABNER-1
Copy link
Member

@ABNER-1 ABNER-1 commented Jun 26, 2024

Ⅰ. Describe what this PR does

add proposal about resize asts pvc

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot kruise-bot requested review from veophi and zmberg June 26, 2024 11:03
@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign veophi for approval by writing /assign @veophi in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot added the size/L size/L: 100-499 label Jun 26, 2024
@ABNER-1 ABNER-1 force-pushed the add-proposal-resize-asts-pvc branch from 495b118 to 9120d23 Compare June 26, 2024 11:10
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.85%. Comparing base (0d0031a) to head (5b9192e).
Report is 76 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1651      +/-   ##
==========================================
+ Coverage   47.91%   48.85%   +0.93%     
==========================================
  Files         162      188      +26     
  Lines       23491    19273    -4218     
==========================================
- Hits        11256     9415    -1841     
+ Misses      11014     8628    -2386     
- Partials     1221     1230       +9     
Flag Coverage Δ
unittests 48.85% <ø> (+0.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ABNER-1 ABNER-1 force-pushed the add-proposal-resize-asts-pvc branch from 9120d23 to 602d86f Compare June 26, 2024 11:34
@ABNER-1 ABNER-1 changed the title add proposal about resize asts pvc [Proposal] add proposal about resize asts pvc Jul 3, 2024
@ABNER-1 ABNER-1 force-pushed the add-proposal-resize-asts-pvc branch 2 times, most recently from f02893f to e617686 Compare July 16, 2024 09:00
Signed-off-by: Abner-1 <yuanyuxing.yyx@alibaba-inc.com>
@ABNER-1 ABNER-1 force-pushed the add-proposal-resize-asts-pvc branch from e617686 to 5b9192e Compare July 29, 2024 12:21
@furykerry furykerry merged commit 9e58975 into openkruise:master Aug 27, 2024
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L size/L: 100-499
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants