-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: New Adapter - Reimbursement #412
Conversation
Codecov Report
@@ Coverage Diff @@
## master #412 +/- ##
==========================================
- Coverage 83.75% 82.09% -1.67%
==========================================
Files 49 55 +6
Lines 1767 1882 +115
Branches 414 438 +24
==========================================
+ Hits 1480 1545 +65
- Misses 287 337 +50
Continue to review full report at Codecov.
|
…ack too deep' error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some minor comments that we already discussed on discord.
…m, not msg.sender
Proposed changes
reimbursable
reimbursable
is protected against reentrancy attacks and calculates the cost of the tx to send the eth back to the caller if the transaction is successfully executedsubmits
&process
proposals were updated to allow reimbursements.