Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: low-issues found with slither fixed/disabled false-positives #413

Merged
merged 11 commits into from
Oct 5, 2021

Conversation

fforbeck
Copy link
Contributor

@fforbeck fforbeck commented Oct 1, 2021

No description provided.

@fforbeck fforbeck self-assigned this Oct 1, 2021
@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #413 (78c5fd0) into master (991c7a1) will increase coverage by 0.98%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #413      +/-   ##
==========================================
+ Coverage   79.25%   80.23%   +0.98%     
==========================================
  Files          48       48              
  Lines        1634     1624      -10     
  Branches      373      381       +8     
==========================================
+ Hits         1295     1303       +8     
+ Misses        339      321      -18     
Impacted Files Coverage Δ
contracts/adapters/BankAdapter.sol 66.66% <ø> (+6.66%) ⬆️
contracts/adapters/Configuration.sol 100.00% <ø> (+5.26%) ⬆️
contracts/adapters/CouponOnboarding.sol 89.65% <ø> (+2.98%) ⬆️
contracts/adapters/DaoRegistryAdapter.sol 100.00% <ø> (+33.33%) ⬆️
contracts/adapters/Distribute.sol 98.52% <ø> (+1.42%) ⬆️
contracts/adapters/ERC1155Adapter.sol 100.00% <ø> (+25.00%) ⬆️
contracts/adapters/Financing.sol 100.00% <ø> (+4.16%) ⬆️
contracts/adapters/GuildKick.sol 95.65% <ø> (+3.98%) ⬆️
contracts/adapters/LendNFT.sol 84.70% <ø> (+0.98%) ⬆️
contracts/adapters/Managing.sol 100.00% <ø> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 991c7a1...78c5fd0. Read the comment docs.

@fforbeck fforbeck changed the title WIP: fix issues found with slither fix: low-issues found with slither fixed/disabled false-positives Oct 4, 2021
@fforbeck fforbeck marked this pull request as ready for review October 4, 2021 19:30
@fforbeck fforbeck added the fix important fix label Oct 4, 2021
@adridadou adridadou merged commit 1f09ee5 into master Oct 5, 2021
@adridadou adridadou deleted the low-issues branch October 5, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix important fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants