Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add deploy for harmony #419

Merged
merged 3 commits into from
Oct 25, 2021
Merged

chore: add deploy for harmony #419

merged 3 commits into from
Oct 25, 2021

Conversation

joequant
Copy link
Contributor

@joequant joequant commented Oct 21, 2021 •
edited by fforbeck
Loading

Added the deployment options for harmony chains:

Main Net

npm run deploy:harmony

Test Net

npm run deploy:harmonytest

fforbeck
fforbeck suggested changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@fforbeck fforbeck left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good @joequant ! Added 2 minor comments about reading the network ids from a single source. After that change it should be good to merge. In addition to that, could you enable the GH actions in your forked repo?

migrations/2_deploy_contracts.js Outdated Show resolved Hide resolved
migrations/2_deploy_contracts.js Outdated Show resolved Hide resolved
@fforbeck fforbeck changed the title add deploy for harmony chore: add deploy for harmony Oct 21, 2021
@fforbeck fforbeck added the chore label Oct 21, 2021
@joequant
Copy link
Contributor Author

It looks good @joequant ! Added 2 minor comments about reading the network ids from a single source. After that change it should be good to merge. In addition to that, could you enable the GH actions in your forked repo?

Added actions. Will fix the networkids.

@joequant
Copy link
Contributor Author

The tests are saying something about a missing ssh key.

@fforbeck fforbeck closed this Oct 25, 2021
@fforbeck fforbeck reopened this Oct 25, 2021
@fforbeck fforbeck merged commit d3df07a into openlawteam:release-v1.0.3 Oct 25, 2021
fforbeck pushed a commit that referenced this pull request Oct 28, 2021
@joequant @fforbeck
chore: add deploy for harmony (#419)
ff012b8 
* add deploy for harmony
* centralize network details on chain
fforbeck pushed a commit that referenced this pull request Oct 29, 2021
@joequant @fforbeck
chore: add deploy for harmony (#419)
a327bbc 
* add deploy for harmony
* centralize network details on chain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fforbeck fforbeck fforbeck approved these changes

Assignees

@joequant joequant

Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joequant @fforbeck