Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New Adapter - KYC Onboarding #437

Merged
merged 16 commits into from
Nov 24, 2021
Merged

feat: New Adapter - KYC Onboarding #437

merged 16 commits into from
Nov 24, 2021

Conversation

adridadou
Copy link
Member

@adridadou adridadou commented Nov 9, 2021

Adds a new KycOnboarding adapter that let's verified individuals to redeem coupons to join the DAO.

Proposed Changes

  • adds the KYC adapter
  • adds WETH helper
  • Allows transfers from multsig address
  • cleans up the deployment script further
  • Docs

@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #437 (99a7d7d) into master (17a89b3) will increase coverage by 0.50%.
The diff coverage is 93.05%.

❗ Current head 99a7d7d differs from pull request most recent head 003e792. Consider uploading reports for the commit 003e792 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #437      +/-   ##
==========================================
+ Coverage   80.96%   81.47%   +0.50%     
==========================================
  Files          46       47       +1     
  Lines        1655     1727      +72     
  Branches      390      411      +21     
==========================================
+ Hits         1340     1407      +67     
- Misses        315      320       +5     
Impacted Files Coverage Δ
contracts/helpers/DaoHelper.sol 88.46% <ø> (ø)
contracts/adapters/KycOnboarding.sol 93.05% <93.05%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17a89b3...003e792. Read the comment docs.

contracts/adapters/KycOnboarding.sol Outdated Show resolved Hide resolved
contracts/adapters/KycOnboarding.sol Outdated Show resolved Hide resolved
contracts/adapters/KycOnboarding.sol Outdated Show resolved Hide resolved
contracts/adapters/KycOnboarding.sol Show resolved Hide resolved
@fforbeck fforbeck changed the title Adapter kyc onboarding feat: New Adapter - KYC Onboarding Nov 16, 2021
@adridadou adridadou marked this pull request as ready for review November 24, 2021 12:46
fforbeck
fforbeck previously approved these changes Nov 24, 2021
@fforbeck fforbeck added the enhancement New feature or request label Nov 24, 2021
@adridadou adridadou merged commit e234a1c into master Nov 24, 2021
@adridadou adridadou deleted the adapter-kyc-onboarding branch November 24, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants