Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: receive and save NFTs sent directly to the extensions #440

Merged
merged 3 commits into from
Nov 24, 2021

Conversation

fforbeck
Copy link
Contributor

Proposed Changes

  • The NFTAdapter was created to collect ERC721 and send them to the ERC721 extension, but the extension contains the onERC721Received function which is called when the token is transferred in the NFT contract, this change fixes the onERC721Received in NFTExtension to save the NFT in the internal storage so the tokens can be sent directly to the extension.
  • Deleted the NFTAdapter and fixed the tests.

@fforbeck fforbeck added the fix important fix label Nov 16, 2021
@fforbeck fforbeck self-assigned this Nov 16, 2021
@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #440 (02347c2) into master (7eb07c9) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #440      +/-   ##
==========================================
+ Coverage   80.85%   80.96%   +0.10%     
==========================================
  Files          47       46       -1     
  Lines        1656     1655       -1     
  Branches      390      390              
==========================================
+ Hits         1339     1340       +1     
+ Misses        317      315       -2     
Impacted Files Coverage Δ
contracts/extensions/nft/NFT.sol 83.01% <100.00%> (+0.66%) ⬆️
...racts/extensions/erc1155/ERC1155TokenExtension.sol 77.02% <0.00%> (+2.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eb07c9...02347c2. Read the comment docs.

@fforbeck fforbeck merged commit 17a89b3 into master Nov 24, 2021
@fforbeck fforbeck deleted the patch/nft-receivers branch November 24, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix important fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants