Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: kyc configs and deployment #452

Merged
merged 1 commit into from
Nov 29, 2021
Merged

fix: kyc configs and deployment #452

merged 1 commit into from
Nov 29, 2021

Conversation

fforbeck
Copy link
Contributor

Proposed Changes

  • Added missing configs for the KYC adapter deployment
  • Renamed some variables to make it clear they belong to the kyc adapter

@fforbeck fforbeck added the fix important fix label Nov 29, 2021
@fforbeck fforbeck self-assigned this Nov 29, 2021
@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #452 (cf833e3) into master (efe4b10) will not change coverage.
The diff coverage is n/a.

❗ Current head cf833e3 differs from pull request most recent head d6057ae. Consider uploading reports for the commit d6057ae to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #452   +/-   ##
=======================================
  Coverage   81.64%   81.64%           
=======================================
  Files          47       47           
  Lines        1743     1743           
  Branches      412      412           
=======================================
  Hits         1423     1423           
  Misses        320      320           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efe4b10...d6057ae. Read the comment docs.

@fforbeck fforbeck force-pushed the patch/kyc-deploy branch 2 times, most recently from 3768bee to 9d6722e Compare November 29, 2021 19:08
Copy link
Member

@jdville03 jdville03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fforbeck thanks for these quick patch fixes.

@fforbeck fforbeck merged commit 37d1256 into master Nov 29, 2021
@fforbeck fforbeck deleted the patch/kyc-deploy branch November 29, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix important fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants