Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: h/m/l issues found with Slither #455

Merged
merged 7 commits into from
Dec 2, 2021
Merged

fix: h/m/l issues found with Slither #455

merged 7 commits into from
Dec 2, 2021

Conversation

fforbeck
Copy link
Contributor

@fforbeck fforbeck commented Dec 2, 2021

Proposed Changes

  • Fixed all High/Medium/Low issues found with Slither, and disabled false positives.
  • There are 3 issues related to the Offchain adapter that will be fixed in another PR (feat: voting rights #451) due to the breaking changes.
  • Updated the slither gh workflow to check for high/med/low issues (it breaks the build if any issue is found).

@fforbeck fforbeck added the fix important fix label Dec 2, 2021
@fforbeck fforbeck self-assigned this Dec 2, 2021
@codecov
Copy link

codecov bot commented Dec 2, 2021

Codecov Report

Merging #455 (7ce24f3) into master (37d1256) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #455   +/-   ##
=======================================
  Coverage   81.64%   81.64%           
=======================================
  Files          47       47           
  Lines        1743     1743           
  Branches      412      412           
=======================================
  Hits         1423     1423           
  Misses        320      320           
Impacted Files Coverage Δ
contracts/adapters/Managing.sol 100.00% <ø> (ø)
...ntracts/adapters/voting/KickBadReporterAdapter.sol 0.00% <ø> (ø)
contracts/extensions/bank/BankFactory.sol 100.00% <ø> (ø)
...ensions/token/erc20/ERC20TokenExtensionFactory.sol 100.00% <ø> (ø)
contracts/adapters/CouponOnboarding.sol 88.88% <100.00%> (ø)
contracts/adapters/KycOnboarding.sol 93.05% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37d1256...7ce24f3. Read the comment docs.

@fforbeck fforbeck marked this pull request as ready for review December 2, 2021 01:13
@fforbeck fforbeck merged commit 9f053ff into master Dec 2, 2021
@fforbeck fforbeck deleted the fix/slither-issues branch December 2, 2021 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix important fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants