Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-02: reset grace period if is a tie #508

Merged
merged 1 commit into from
Mar 3, 2022
Merged

fix-02: reset grace period if is a tie #508

merged 1 commit into from
Mar 3, 2022

Conversation

fforbeck
Copy link
Contributor

@fforbeck fforbeck commented Mar 1, 2022

If a new vote result is submitted and it changes the result status from PASS to TIE, the grace period is not reset. A TIE should not be treated as the same as a NOT_PASS, otherwise any member can abuse it to deny vote proposals before execution.

Proposed Changes

  • Reset the grace period if the last vote result status is a TIE.

@fforbeck fforbeck added the fix important fix label Mar 1, 2022
@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #508 (e526ef6) into master (bef1c72) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #508   +/-   ##
=======================================
  Coverage   82.27%   82.27%           
=======================================
  Files          53       53           
  Lines        1851     1851           
  Branches      430      430           
=======================================
  Hits         1523     1523           
  Misses        328      328           
Impacted Files Coverage Δ
contracts/adapters/voting/OffchainVoting.sol 41.25% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bef1c72...e526ef6. Read the comment docs.

@fforbeck fforbeck requested a review from adridadou March 1, 2022 21:06
@fforbeck fforbeck assigned fforbeck and adridadou and unassigned adridadou Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix important fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants