Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-03: track redeemed kyc coupons #509

Merged
merged 2 commits into from
Mar 3, 2022
Merged

fix-03: track redeemed kyc coupons #509

merged 2 commits into from
Mar 3, 2022

Conversation

fforbeck
Copy link
Contributor

@fforbeck fforbeck commented Mar 1, 2022

Proposed Changes

  • Members that already joined the DAO using a KYCed coupon, shouldn't be able to join again using the same coupon.

@fforbeck fforbeck added the fix important fix label Mar 1, 2022
@fforbeck fforbeck requested a review from adridadou March 1, 2022 21:06
@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #509 (cb3a24d) into master (bef1c72) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head cb3a24d differs from pull request most recent head 69dce7b. Consider uploading reports for the commit 69dce7b to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #509      +/-   ##
==========================================
+ Coverage   82.27%   82.30%   +0.02%     
==========================================
  Files          53       53              
  Lines        1851     1854       +3     
  Branches      430      431       +1     
==========================================
+ Hits         1523     1526       +3     
  Misses        328      328              
Impacted Files Coverage Δ
contracts/adapters/voting/OffchainVoting.sol 41.25% <ø> (ø)
contracts/adapters/KycOnboarding.sol 93.33% <100.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99f4803...69dce7b. Read the comment docs.

@fforbeck fforbeck merged commit f15e12c into master Mar 3, 2022
@fforbeck fforbeck deleted the trb-03 branch March 3, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix important fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants