Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-20: save N tokens from the same nft contract addr #514

Merged
merged 2 commits into from
Mar 3, 2022
Merged

Conversation

fforbeck
Copy link
Contributor

@fforbeck fforbeck commented Mar 2, 2022

Proposed Changes

  • It should be possible to save/accept different token ids from the same nft contract address.

@fforbeck fforbeck added the fix important fix label Mar 2, 2022
@fforbeck fforbeck requested a review from adridadou March 2, 2022 19:11
@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #514 (3a188de) into master (ee146fa) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 3a188de differs from pull request most recent head 16a779a. Consider uploading reports for the commit 16a779a to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #514   +/-   ##
=======================================
  Coverage   82.30%   82.31%           
=======================================
  Files          53       53           
  Lines        1854     1855    +1     
  Branches      431      431           
=======================================
+ Hits         1526     1527    +1     
  Misses        328      328           
Impacted Files Coverage Δ
contracts/extensions/nft/NFT.sol 83.33% <100.00%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee146fa...16a779a. Read the comment docs.

@fforbeck fforbeck merged commit 8cabbac into master Mar 3, 2022
@fforbeck fforbeck deleted the trb-20 branch March 3, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix important fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants