Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-25: remove the previous nft owner if balance=0 #515

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Conversation

fforbeck
Copy link
Contributor

@fforbeck fforbeck commented Mar 2, 2022

Proposed Changes

  • Fixed the _nftTracker and _ownership mappings to remove the correct account when an NFT is moved out of the extension contract.

@fforbeck fforbeck added the fix important fix label Mar 2, 2022
@fforbeck fforbeck requested a review from adridadou March 2, 2022 21:10
@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #515 (5d8e8d3) into master (d83470d) will increase coverage by 0.38%.
The diff coverage is 100.00%.

❗ Current head 5d8e8d3 differs from pull request most recent head 8a80c51. Consider uploading reports for the commit 8a80c51 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #515      +/-   ##
==========================================
+ Coverage   83.28%   83.67%   +0.38%     
==========================================
  Files          53       53              
  Lines        1855     1856       +1     
  Branches      431      431              
==========================================
+ Hits         1545     1553       +8     
+ Misses        310      303       -7     
Impacted Files Coverage Δ
contracts/adapters/KycOnboarding.sol 93.33% <100.00%> (ø)
...racts/extensions/erc1155/ERC1155TokenExtension.sol 97.22% <100.00%> (+9.72%) ⬆️
contracts/test/ERC1155TestAdapter.sol 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d83470d...8a80c51. Read the comment docs.

adridadou
adridadou previously approved these changes Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix important fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants