Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-30: reimburse the from account #519

Merged
merged 3 commits into from
Mar 8, 2022
Merged

fix-30: reimburse the from account #519

merged 3 commits into from
Mar 8, 2022

Conversation

fforbeck
Copy link
Contributor

@fforbeck fforbeck commented Mar 7, 2022

Proposed Changes

  • When a token is received the account that needs to be reimbursed is the from account, and not the msg.sender - which in this case is the actual token contract.

@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #519 (3b84038) into master (0746391) will increase coverage by 0.97%.
The diff coverage is 100.00%.

❗ Current head 3b84038 differs from pull request most recent head 3db775c. Consider uploading reports for the commit 3db775c to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #519      +/-   ##
==========================================
+ Coverage   82.31%   83.28%   +0.97%     
==========================================
  Files          53       53              
  Lines        1855     1855              
  Branches      431      431              
==========================================
+ Hits         1527     1545      +18     
+ Misses        328      310      -18     
Impacted Files Coverage Δ
contracts/adapters/BankAdapter.sol 100.00% <100.00%> (+18.18%) ⬆️
contracts/adapters/LendNFT.sol 97.59% <100.00%> (+9.49%) ⬆️
contracts/extensions/bank/Bank.sol 80.57% <0.00%> (+5.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a8e3e0...3db775c. Read the comment docs.

@fforbeck fforbeck marked this pull request as ready for review March 7, 2022 18:33
@fforbeck fforbeck requested a review from adridadou March 7, 2022 18:33
@fforbeck fforbeck added the fix important fix label Mar 7, 2022
@fforbeck fforbeck merged commit 318d426 into master Mar 8, 2022
@fforbeck fforbeck deleted the trb-30 branch March 8, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix important fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants