-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(offchain-voting): remove duplicate checks; set node index to start from 1; tests #534
Conversation
Codecov Report
@@ Coverage Diff @@
## master #534 +/- ##
==========================================
+ Coverage 85.59% 90.72% +5.13%
==========================================
Files 52 52
Lines 1867 1866 -1
Branches 438 438
==========================================
+ Hits 1598 1693 +95
+ Misses 269 173 -96
Continue to review full report at Codecov.
|
1f08d07
to
3515fe4
Compare
Proposed Changes
_verifyNode
redundant check fromOffchainVoting.sol
isReadyToSubmitResult
check for every new vote resultcheckMemberCount
fromOffchainVotingHelper.sol
andOffchainVoting.submitResult
because this check is already done viagetBadNodeError.INDEX_OUT_OF_BOUNDS
.challengeMissingStep
- missing the ACLs to submit the proposals and jail members.revert
messages.