Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deploy): log the blockNumber #595

Merged
merged 1 commit into from
Mar 21, 2023
Merged

fix(deploy): log the blockNumber #595

merged 1 commit into from
Mar 21, 2023

Conversation

fforbeck
Copy link
Contributor

@fforbeck fforbeck commented Mar 21, 2023

Proposed Changes

  • Updated the deployment logs to print out the block number of the dao.finalizeDao call. Useful for services that will index the DAO activity.

Sample output:

[job-e6df4069-dada-4b4f-8480-3fc7d8811892]  Finalize DAO creation...
[job-e6df4069-dada-4b4f-8480-3fc7d8811892] 
[job-e6df4069-dada-4b4f-8480-3fc7d8811892]       waiting for transaction to be submitted / mined
[job-e6df4069-dada-4b4f-8480-3fc7d8811892]       submitted! tx hash:0x3e4aac51937c5be0a93f97e38df84d8bb06ecf1c66d39e8c558d6585681c874b - nonce:1572
[job-e6df4069-dada-4b4f-8480-3fc7d8811892]       transaction mined
[job-e6df4069-dada-4b4f-8480-3fc7d8811892] 
[job-e6df4069-dada-4b4f-8480-3fc7d8811892]  DAO finalized @ blockNumber: 1573

@fforbeck fforbeck requested a review from jdville03 March 21, 2023 18:46
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #595 (de1fbbf) into master (ed2a0fb) will not change coverage.
The diff coverage is n/a.

❗ Current head de1fbbf differs from pull request most recent head aa02a24. Consider uploading reports for the commit aa02a24 to get more accurate results

@@           Coverage Diff           @@
##           master     #595   +/-   ##
=======================================
  Coverage   90.84%   90.84%           
=======================================
  Files          55       55           
  Lines        2032     2032           
  Branches      462      462           
=======================================
  Hits         1846     1846           
  Misses        186      186           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fforbeck fforbeck merged commit 94e28ef into master Mar 21, 2023
@fforbeck fforbeck deleted the log-blockNumber branch March 21, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants