Extra TS syntax support #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daniel-Knights
force-pushed
the
extra-ts-syntax-support
branch
from
4342964
to
a6dbcf9
Compare
tschaub
reviewed
Aug 23, 2024
…ons for newly supported TS syntax
Daniel-Knights
force-pushed
the
extra-ts-syntax-support
branch
from
fbed3b6
to
c51ebc3
Compare
ahocevar
requested changes
Sep 9, 2024
|
Thanks for the updated regular expression, which looks good now. I apologize for having merged the other pull requests first, which causes nasty conflicts in this one. Would you be able to squash the commits and resolve the conflicts? Thanks a lot for your effort! |
Merged
|
@Daniel-Knights I created #63 with your changes from here, but with the conflicts resolved. Thanks for your effort! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for:
@defaultand@membertagsOther changes:
inheritoption forstdoutin the JSDocspawncall for easier debugging when running testsBasic Prettier configAdditional notes
The semi-colon and trailing comma replacements seem a bit risky, but the only instance I can think of where this could be an issue is in exact string types, e.g.
@type {"a;b"}would become@type {"a,b"}. It's an edge case, but probably good enough reason not to include it. Added it anyway in case you see otherwise.