AC-1080: Appointment Scheduling Integration #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AC-1080: Add representation AC-1080: Add repository AC-1080: Refactor properties
…penmrs/openmrs-contrib-android-client into AC-1080-Appointment-Scheduling
…penmrs/openmrs-contrib-android-client into AC-1080-Appointment-Scheduling
rishabh-997
requested changes
Jun 26, 2023
.idea/runConfigurations.xml
Outdated
| @@ -1,12 +0,0 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
Undo changes that are not relevant
|
|
||
| class TimeSlot( | ||
|
|
||
| @Expose var appointmentBlock: AppointmentBlock? = null, |
There was a problem hiding this comment.
Suggested change
| @Expose var appointmentBlock: AppointmentBlock? = null, | |
| @Expose | |
| var appointmentBlock: AppointmentBlock? = null, |
| @@ -0,0 +1,30 @@ | |||
| package com.openmrs.android_sdk.library.models | |||
|
|
||
| class Appointment( | ||
|
|
||
| @Expose var timeSlot: TimeSlot? = null, |
There was a problem hiding this comment.
Suggested change
| @Expose var timeSlot: TimeSlot? = null, | |
| @Expose | |
| var timeSlot: TimeSlot? = null, |
Comment on lines
17
to
20
|
|
||
|
|
||
|
|
||
|
|
| import javax.inject.Singleton | ||
|
|
||
| @Singleton | ||
| class AppointmentRepository @Inject constructor() : BaseRepository(){ |
There was a problem hiding this comment.
Suggested change
| class AppointmentRepository @Inject constructor() : BaseRepository(){ | |
| class AppointmentRepository @Inject constructor() : BaseRepository() { |
Comment on lines
60
to
61
| } | ||
| ) |
There was a problem hiding this comment.
Suggested change
| } | |
| ) | |
| }) |
| * | ||
| * @return the TimeSlot object | ||
| */ | ||
| fun createTimeSlot(timeSlot: TimeSlot): Observable<TimeSlot>{ |
There was a problem hiding this comment.
Add spacing in all remaining functions
Comment on lines
82
to
83
| } | ||
| ) |
There was a problem hiding this comment.
Suggested change
| } | |
| ) | |
| } | |
| ) |
Suggested change
| } | |
| ) | |
| }) |
Add this change in all remaining functions
Comment on lines
104
to
109
| if (response.isSuccessful && response != null) { | ||
| return@Callable response.body()!! | ||
| } else { | ||
| logger.e("Error creating Time Slot: " + response.message()) | ||
| throw Exception(response.message()) | ||
| } |
There was a problem hiding this comment.
You can create a function instead of repeating the same lines
There was a problem hiding this comment.
Indeed! Updated the PR by creating a function using Generics
…penmrs/openmrs-contrib-android-client into AC-1080-Appointment-Scheduling
Undo irrelevant changes
shubhamsgit
commented
Jun 28, 2023
.idea/runConfigurations.xml
Outdated
There was a problem hiding this comment.
Reverted the irrelevant changes
|
Pushed the requested changes. Please have a look now :) |
rishabh-997
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what I changed
Issue I worked on
JIRA Issue: https://issues.openmrs.org/browse/AC-1080
Checklist: I completed these to help reviewers :)
(the number above, next to the 'Commits' tab is 1).
existing code that was well tested you do not have to add tests)