Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) O3-1426: Modals should not be registered as extensions #6

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

brandones
Copy link
Contributor

@brandones brandones commented Mar 28, 2024

Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @brandones.

@denniskigen denniskigen changed the title (feat) O3-1426 Modals should not be extensions (feat) O3-1426: Modals should not be registered as extensions Apr 4, 2024
@ibacher
Copy link
Member

ibacher commented Apr 5, 2024

I suppose we need to start versioning this schema...

@ibacher ibacher marked this pull request as ready for review April 5, 2024 13:50
@ibacher ibacher merged commit 511b6b8 into main Apr 5, 2024
@ibacher ibacher deleted the modals branch April 5, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants