Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) O3-3415 : Update scroll height in form-renderer and interactive-builder #297

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

senthil-athiban
Copy link
Contributor

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Fixing the height of the form-renderer and interactive builder, and including a scrollbar if contents overflow. This will be useful when the user makes changes using an interactive builder, as the changes can be seen in the schema editor simultaneously.

Screenshots

Before:
https://www.loom.com/share/cd32179bb6c54e8fb368427dd4e1a3c7?sid=949250bb-7eaa-4e27-b0d1-abfbfc8219a2

After:
https://www.loom.com/share/2d421a86876941e59f91b9d30979ac34?sid=3d3ea380-326c-4d72-a574-dc92906afff8

Related Issue

https://openmrs.atlassian.net/browse/O3-3415

@senthil-athiban senthil-athiban changed the title (fix): Update scroll height in form-renderer and interactive-builder (fix) O3-3415 : Update scroll height in form-renderer and interactive-builder Jun 13, 2024
@NethmiRodrigo
Copy link
Contributor

Screenshot 2024-08-22 at 12 11 50 PM @senthil-athiban could we have both the interactive builder and the JSON schema editor take up the same height? The interactive builder seems to be a little shorter.

@NethmiRodrigo
Copy link
Contributor

Sorry about the late review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants