Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Consistently style multi-select field labels #304

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

samuelmale
Copy link
Member

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR aims at fixing a few minor issues related to #232. It basically:

  1. Ensures that a required field's label is highlighted using an asterisk
  2. Ensures that the field label is styled conventionally

Screenshots

Before:

Screenshot 2024-06-05 at 02 45 12

After:

Screenshot 2024-06-05 at 02 43 31

Related Issue

Other

@samuelmale samuelmale changed the title (fix) Consistently highlight a required field's label for multi-select rendering (fix) Consistently style a multi-select field label Jun 4, 2024
Copy link

github-actions bot commented Jun 4, 2024

Size Change: +81 B (+0.01%)

Total Size: 1.04 MB

ℹ️ View Unchanged
Filename Size Change
dist/184.js 11.2 kB 0 B
dist/225.js 2.56 kB 0 B
dist/29.js 157 kB 0 B
dist/300.js 706 B 0 B
dist/31.js 5.28 kB 0 B
dist/318.js 2.42 kB 0 B
dist/327.js 1.83 kB 0 B
dist/335.js 955 B 0 B
dist/353.js 3.02 kB 0 B
dist/371.js 71.3 kB 0 B
dist/41.js 3.36 kB 0 B
dist/436.js 752 B 0 B
dist/465.js 181 kB 0 B
dist/540.js 2.64 kB 0 B
dist/55.js 2.13 kB 0 B
dist/635.js 14.3 kB 0 B
dist/708.js 245 kB +40 B (+0.02%)
dist/8.js 3.67 kB 0 B
dist/979.js 6.85 kB 0 B
dist/99.js 690 B 0 B
dist/993.js 3.08 kB 0 B
dist/998.js 15.5 kB 0 B
dist/main.js 300 kB +41 B (+0.01%)
dist/openmrs-form-engine-lib.js 3.75 kB 0 B

compressed-size-action

Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @samuelmale!

@denniskigen denniskigen changed the title (fix) Consistently style a multi-select field label (fix) Consistently style multi-select field labels Jun 5, 2024
@denniskigen denniskigen merged commit 20897d7 into main Jun 5, 2024
4 checks passed
@denniskigen denniskigen deleted the fix/multiSelectFieldLabel branch June 5, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants