(test) Adding test coverage for encounter location handler #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirupius
changed the title
pirupius
reviewed
Jun 5, 2024
Comment on lines
219
to
228
| const field: FormField = { | ||
| label: 'Encounter Location', | ||
| type: 'encounterLocation', | ||
| required: false, | ||
| id: 'encounterLocation', | ||
| questionOptions: { | ||
| rendering: 'ui-select-extended', | ||
| }, | ||
| validators: [], | ||
| }; |
There was a problem hiding this comment.
@samuelmale is this a pattern that will be maintained? The field definition seems to be repeated throughout the file but it's the same content. Or is it this way so each instance in the test is independent?
There was a problem hiding this comment.
I think for this scenario it should be possible to reuse a single field object across the suite. We can then add a cleanup or teardown callback that ensures that the side effects from the previous tests are cleaned up
There was a problem hiding this comment.
thanks @pirupius @samuelmale ..
i have added a tear down
pirupius
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Adding test coverage for the encounter location handler for handlingFieldSubmission, getting initial and previous values plus getDisplay value
Screenshots
Related Issue
Other