(refactor): change modal registration name

openmrs · May 24, 2024 · 0fbeb89 · 0fbeb89
1 parent 5ba553e
commit 0fbeb89
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/packages/esm-form-engine-app/src/form-renderer/form-renderer.component.tsx b/packages/esm-form-engine-app/src/form-renderer/form-renderer.component.tsx
@@ -37,7 +37,7 @@ const FormRenderer: React.FC<FormRendererProps> = ({
 
   const handleConfirmQuestionDeletion = useCallback(() => {
     return new Promise<void>((resolve, reject) => {
-      const dispose = showModal('delete-question-confirm-modal', {
+      const dispose = showModal('form-engine-delete-question-confirm-modal', {
         onCancel() {
           dispose();
           reject();

diff --git a/packages/esm-form-engine-app/src/form-renderer/repeat/delete-question-modal.component.tsx b/packages/esm-form-engine-app/src/form-renderer/repeat/delete-question-modal.component.tsx
@@ -11,7 +11,7 @@ const DeleteModal: React.FC<DeleteModalProps> = ({ onConfirm, onCancel }) => {
   const { t } = useTranslation();
 
   return (
-    <div>
+    <React.Fragment>
       <ModalHeader
         closeModal={onCancel}
         title={t('deleteQuestionConfirmation', 'Are you sure you want to delete this question?')}
@@ -27,7 +27,7 @@ const DeleteModal: React.FC<DeleteModalProps> = ({ onConfirm, onCancel }) => {
           {t('deleteQuestion', 'Delete question')}
         </Button>
       </ModalFooter>
-    </div>
+    </React.Fragment>
   );
 };
 

diff --git a/packages/esm-form-engine-app/src/routes.json b/packages/esm-form-engine-app/src/routes.json
@@ -17,7 +17,7 @@
   ],
   "modals": [
     {
-      "name": "delete-question-confirm-modal",
+      "name": "form-engine-delete-question-confirm-modal",
       "component": "deleteQuestionModal"
     }
   ],