Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) O3-3175: Remove Breadcrumbs menu from Patient Chart #1832

Merged
merged 3 commits into from
May 22, 2024
Merged

(fix) O3-3175: Remove Breadcrumbs menu from Patient Chart #1832

merged 3 commits into from
May 22, 2024

Conversation

kb019
Copy link
Contributor

@kb019 kb019 commented May 10, 2024 •
edited by denniskigen
Loading

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR removes the Breadcrumbs navigation pattern from the Patient Chart.

Screenshots

image

Related Issue

https://openmrs.atlassian.net/browse/O3-3175

@denniskigen denniskigen changed the title (fix)- O3-3175 Remove Breadcrumbs (fix) O3-3175: Remove Breadcrumbs menu from Patient Chart May 22, 2024
denniskigen
denniskigen approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @kb019!

@denniskigen denniskigen merged commit 7c72bc1 into openmrs:main May 22, 2024
6 checks passed
@kb019
Copy link
Contributor Author

kb019 commented May 22, 2024

Hey @denniskigen , Thanks a lot.

alaboso added a commit that referenced this pull request May 27, 2024
@alaboso @mogoodrich
@Madhu-mac @mozzy11 @denniskigen @samuelmale @ibacher @donaldkibet @arodidev @jona42-ui @piyushmishra1416 @vasharma05 @kb019 @jwnasambu @xprl-gjf @NethmiRodrigo
Update new-visits-widget with work in main (#1850)
52e8a60 
* (feat) O3-3156: Submitting the start visit form should mutate appointments (#1825)

* (fix) O3-2852: Fix the viewport size of the Start Visit form on tablet (#1765)

* Overlapping issue fixed in visit-form

* Make viewport height responsive - different values for desktop and tablet

---------

Co-authored-by: Mutesasira Moses <mozzymutesa@gmail.com>
Co-authored-by: Dennis Kigen <kigen.work@gmail.com>

* (refactor) O3-2626: Reuse useAllowedFileExtensions hook from Common Lib (#1827)

(refactor) Reuse allowedFileExtensions hook from Common Lib

* (feat) O3-3158: Conditionally render Patient Header in the Start Visit form (#1823)

* (feat) O3-3158: Visit Form should support (optionally) rendering Patient Header

* (feat) O3-3158: Visit Form should support (optionally) rendering Patient Header

---------

Co-authored-by: Dennis Kigen <kigen.work@gmail.com>

* (chore) Bump form-engine lib (#1828)

Bump form-engine lib

* (chore) Bump form-engine lib (#1829)

Bump form-engine lib

* (fix) Widen range to detect "current" data entry

* (fix) O3-3158: Follow-up commit fixing patientUuid sometimes undefined (#1831)

* (feat) O3 3128: Add extension slots to lab and drug order forms (#1818)

* (feat) Add slots to labs and drug form

* O3-3128 (feat) Enhance lab, orders and dispensing form with addition slot

* Fixup

---------

Co-authored-by: Dennis Kigen <kigen.work@gmail.com>

* (chore) Bump RFE version (#1833)

* Bump RFE version

* Update to next

* (fix) O3-3196: Fix diagnoses tags display on tablet (#1834)

* (fix) O3-3195: Fix rendering logic for the weight tile (#1835)

* (fix) return encounter type uuid from encounter type object (#1836)

return uuid from encounter type object

* (chore) Bump React form engine and yarn (#1837)

* (chore) Release v8.0.0 (#1839)

* (feat) O3-2430: User should be able to look up frequency in dropdown by abbreviation (#1767)

Co-authored-by: Dennis Kigen <kigen.work@gmail.com>
Co-authored-by: Ian <52504170+ibacher@users.noreply.github.com>

* (chore) Release v8.0.1 (#1841)

Co-authored-by: Dennis Kigen <kigen.work@gmail.com>

* (chore) Bump react and related types (#1842)

* (chore) Bump react and related types

* Fixup

* Bump test deps to remove warnings

* (fix) O3-3158: Restore abortControllers

* Revert "(fix) O3-3158: Restore abortControllers"

This reverts commit 0895e27.

* (fix) O3-3158: Restore abortControllers (#1843)

* (chore) Bump react form engine

* (fix) O3-3175: Remove Breadcrumbs menu from Patient Chart (#1832)

* (fix)- O3-3175 Remove Breadcrumbs

* Remove translation strings

* Remove more occurrences of breadcrumbs

---------

Co-authored-by: Dennis Kigen <kigen.work@gmail.com>

* (feat) Update custom representation to match required properties for encounter observation (#1845)

* Make attachment upload modal span full-width

* (chore) Bump react form engine (#1846)

* (feat) O3-2626: Add the ability to upload multiple images in the Visit Note form (#1826)

Co-authored-by: Dennis Kigen <kigen.work@gmail.com>

* (fix) O3-3284: Display correctly formatted patient name throughout patient chart apps (#1849)

* Display formatted patient name in visit-header and patient-details-tile components

* Display formatted patient name in patient-banner component.

* Display formatted patient name in esm-patient-labs-app

* Display formatted patient name in esm-patient-medications-app

* Display formatted patient name in esm-patient-orders-app

* Display formatted patient name in esm-patient-vitals-app

* Bump core tooling

* (feat) O3-3165: Add confirmation modal when deleting repeat question (#1840)

* (feat): Add confirmation modal when deleting repeat question

* (refactor): register modal as extension

* (refactor): change modal registration name

* Bump form engine and core tooling

---------

Co-authored-by: Dennis Kigen <kigen.work@gmail.com>

---------

Co-authored-by: Mark Goodrich <mgoodrich@pih.org>
Co-authored-by: Madhu Lokesh <madhumj623@gmail.com>
Co-authored-by: Mutesasira Moses <mozzymutesa@gmail.com>
Co-authored-by: Dennis Kigen <kigen.work@gmail.com>
Co-authored-by: Samuel Male <samuelsmalek@gmail.com>
Co-authored-by: Ian <ian.c.bacher@gmail.com>
Co-authored-by: Ian <52504170+ibacher@users.noreply.github.com>
Co-authored-by: Donald Kibet <chelashawdonald@yahoo.com>
Co-authored-by: Jamie Arodi <51090527+arodidev@users.noreply.github.com>
Co-authored-by: Thembo Jonathan <jonathanthembo123@gmail.com>
Co-authored-by: Piyush Mishra <91911367+piyushmishra1416@users.noreply.github.com>
Co-authored-by: Vineet Sharma <sharmava05@gmail.com>
Co-authored-by: Bhargav kodali <115476530+kb019@users.noreply.github.com>
Co-authored-by: jwnasambu <33891016+jwnasambu@users.noreply.github.com>
Co-authored-by: Gavin Falconer <gfalconer@xprl.co.uk>
Co-authored-by: Nethmi Rodrigo <34070216+NethmiRodrigo@users.noreply.github.com>
arodidev pushed a commit to arodidev/openmrs-esm-patient-chart that referenced this pull request May 28, 2024
@kb019 @denniskigen @arodidev
(fix) O3-3175: Remove Breadcrumbs menu from Patient Chart (openmrs#1832)
f23d504 
* (fix)- O3-3175 Remove Breadcrumbs

* Remove translation strings

* Remove more occurrences of breadcrumbs

---------

Co-authored-by: Dennis Kigen <kigen.work@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denniskigen denniskigen denniskigen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kb019 @denniskigen