Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empt64 #141

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Empt64 #141

wants to merge 5 commits into from

Conversation

Parth59
Copy link
Contributor

@Parth59 Parth59 commented Mar 13, 2021

@isears

Changes I made:
Added input-validation to the backend variables. Steps to reproduce can be found here.
https://docs.google.com/document/d/1GJNMRlGTRV45St6WSjnD_FjW84aoNxY9HzGbpwoBrro/edit?usp=sharing

Link to ticket:
https://issues.openmrs.org/browse/RA-1865

@HerbertYiga
Copy link
Contributor

thanks @Parth59 for working on this, you can checkout https://wiki.openmrs.org/display/docs/Pull+Request+Tips to make better pull requests

@isears
Copy link
Member

isears commented Mar 18, 2021

@Parth59 what do you think of inspecting the Provider object in the DWR provider search service and applying HTML-encoding server-side?

The relevant server-side code for the provider search function is here:

Looks like something similar was done to patch another XSS issue a few years back (#77), so you will already have access to encoding functions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants