Identified and handled global properties and missing values #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pdated this module to gracefully handle missing values for these global properties.
…i module, and updated this module to gracefully handle missing values for these global properties, though some of the removed GPs were not having usecase in the implementation
|
Have you gone through different tickets and see how we can make a good ticket header. |
jona42-ui
changed the title
ooops! that was so long a header, have edited it. thanks @sherrif10 |
sherrif10
reviewed
Sep 24, 2023
| @@ -82,6 +82,19 @@ | |||
| } | |||
| return false; | |||
| } | |||
|
|
|||
| //hide the feature(concepts that are not defined either by property or value). | |||
| window.onload = function showOrHide() { | |||
There was a problem hiding this comment.
Well done on this. Do you mind sharing a small vedio or screenshots for this fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what I changed
Identified where these global properties are used and update this module to gracefully handle missing values for these global properties. and i mainly found them in patientDashboardForm.jsp and patirntOverview.jsp
this i PR is based on issue;
https://issues.openmrs.org/browse/LUI-175