Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sticky header hide and show on scroll and visible login access #72

Closed
wants to merge 40 commits into from

Conversation

ElviaBth
Copy link
Collaborator

@ElviaBth ElviaBth commented May 27, 2024

🎩 What? Why?

Sticky header hide and show on scroll and visible login access

📌 Related Issues

Testing

You can visit with a mobile browser.

  • The sticky header hides and displays if the user scrolls down and then scrolls up.
  • See the header, which has visible login access.
  • Click the menu.
  • The menu has a search and a language chooser.

📷 Screenshots

image
header default
image
header login photo
image
add search added to the menu and language chooser to dropdown menu

♥️ Thank you!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['type: feature', 'type: change', 'type: fix', 'type: removal', 'target: developer-experience', 'type: internal']

@ElviaBth ElviaBth added enhancement New feature or request feature and removed enhancement New feature or request labels May 27, 2024
Copy link

@microstudi microstudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ElviaBth I've left you some comment to solve the duplicated IDs

Copy link

@carolromero carolromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ElviaBth! I found I couple of things missing when reviewing this:

  • On mobile I don't see the switch of the logo to the favicon
  • When I log in as admin, I don't see the avatar and the access to the user menu
  • When I log in as a participant with no avatar associated, I don't see the avatar by default and the access to the user menu
  • When I log in as a participant, I do see the avatar and the user menu, but I miss the indicator of pending notifications/conversations, this one 👇
    image

The language selector and the search inside the hamburger menu work perfect!

@microstudi microstudi closed this Jun 4, 2024
Copy link

@carolromero carolromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! We've checked again and we are almost there! A couple of last adjustments:

  • The margin between menu and avatar gets misaligned if the avatar has no image. I'm attaching screenshots for comparison (the correct margin is like the one with image):
    image
    image

  • On the other hand, the notification indicator should be displayed as in the avatar example without image, otherwise it is too far apart.

  • As we are using the initial when the avatar has no image, we should apply it here as well.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants