Refactor user model to include private fields explicitly #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace it with models.PrivateUser call. remove helper for getting private info out of the user type. directly embed the private fields into the response.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update to the user model declares the fields which are private and should not be displayed to other users. These fields are embedded into the
Usertype asPrivateUserand can be directly accessed as they were previously called viaUser.EmailorUser.APIKey. This change allows the Private fields to be accessed/retrieved as a whole instead of individually knowing what is or is not private. This also helps us prevent these fields from being accidentally leaked.ApiKeywas renamed toAPIKeyto be consistent with language standards for initialisms https://go.dev/wiki/CodeReviewComments#initialisms