Replace PublicUserType with models.PublicUser type #355
+5
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajlacey
commented
Sep 29, 2024
Comment on lines
-58
to
-61
| if err != nil { | ||
| http.Error(w, "Error retrieving number of users.", http.StatusInternalServerError) | ||
| return | ||
| } |
There was a problem hiding this comment.
There are no errors currently returned by the call to GetNumMarketUsers(bets)
Comment on lines
-13
to
-27
| // PublicUserType is a struct for user data that is safe to send to the client for Profiles | ||
| type PublicUserType struct { | ||
| Username string `json:"username"` | ||
| DisplayName string `json:"displayname" gorm:"unique;not null"` | ||
| UserType string `json:"usertype"` | ||
| InitialAccountBalance int64 `json:"initialAccountBalance"` | ||
| AccountBalance int64 `json:"accountBalance"` | ||
| PersonalEmoji string `json:"personalEmoji,omitempty"` | ||
| Description string `json:"description,omitempty"` | ||
| PersonalLink1 string `json:"personalink1,omitempty"` | ||
| PersonalLink2 string `json:"personalink2,omitempty"` | ||
| PersonalLink3 string `json:"personalink3,omitempty"` | ||
| PersonalLink4 string `json:"personalink4,omitempty"` | ||
| } | ||
|
|
There was a problem hiding this comment.
All of these fields are just being re-declared from the model. By making them a component type of the model User, we can access them all together.
j4qfrost
approved these changes
Sep 29, 2024
Yeah, this is just how the changes to the model in #354 are going to be used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the new PublicUser type from the model in the user handlers.