Remove inputstream finalizer #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-java into remove-inputstream-finalizer
timtebeek
reviewed
Jun 27, 2023
src/main/java/org/openrewrite/java/migrate/io/RemoveFinalizeFromFileStream.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/migrate/io/RemoveFinalizeFromFileStream.java
Outdated
Show resolved
Hide resolved
|
Thank you for your detailed inputs. I've made the necessary changes. Please review them. |
src/main/java/org/openrewrite/java/migrate/io/RemoveFinalizeFromFileStream.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/migrate/io/RemoveFinalizeFromFileStream.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/migrate/io/RemoveFinalizeFromFileStream.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/migrate/io/RemoveFinalizeFromFileStream.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/migrate/io/RemoveFinalizeFromFileStream.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/migrate/io/RemoveFinalizeFromFileStream.java
Outdated
Show resolved
Hide resolved
timtebeek
reviewed
Jul 12, 2023
src/main/java/org/openrewrite/java/migrate/io/RemoveFinalizeFromFileStream.java
Outdated
Show resolved
Hide resolved
timtebeek
reviewed
Jul 17, 2023
src/main/java/org/openrewrite/java/migrate/io/RemoveFinalizeFromFileStream.java
Outdated
Show resolved
Hide resolved
joanvr
reviewed
Jul 17, 2023
src/main/java/org/openrewrite/java/migrate/io/RemoveFinalizeFromFileStream.java
Outdated
Show resolved
Hide resolved
timtebeek
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
Thanks for getting this started @satvika-eda !
@joanvr Would you mind having another look for a review of my changes? That way it's not just me.
joanvr
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
finalize method has been removed from the FileInputStream and FileOutputStream of the io package for which the needed automation has been done as part of the recipe created
What's your motivation?
To automate JDK migration to a greater extent
Checklist
./gradlew licenseFormat