remove thread destroy method recipe

[satvika-eda]

What's changed?

To remove Thread.destroy deprecated method

What's your motivation?

To automate JDK migration to a greater extent

Checklist

• I've added unit tests to cover both positive and negative cases
• I've added the license header to any new files through ./gradlew licenseFormat
• I've used the IntelliJ auto-formatter on affected files
• I've updated the documentation (if applicable)

[timtebeek]

For context: https://bugs.openjdk.org/browse/JDK-8204260

[timtebeek]

Thanks a lot for implementing this one! Some of the same concerns regarding the use of the type system as in #247 apply here, but I don't think there's anything much we can do about that. Some smaller suggestions that when applied can lead to a merge.

[timtebeek]

You can use Markdown around code snippets here and in the description such that it'll look slightly better in the documentation.

Suggested change

	return "Remove deprecated Thread.destroy() statement";
	return "Remove deprecated `Thread.destroy()`";

[timtebeek]

Suggested change

	return "Remove deprecated invocations of Thread.destroy() which have no alternatives needed.";
	return "Remove deprecated invocations of `Thread.destroy()` which have no alternatives needed.";

[timtebeek]

I don't there's anything specific around the Java version of the sources here right? Maybe best to then not explicitly set any markers, as it could cause confusion

Suggested change

	spec.recipe(new RemoveThreadDestroyMethod()).allSources(s -> s.markers(javaVersion(8)));
	spec.recipe(new RemoveThreadDestroyMethod());

[timtebeek]

Suggest to add some newlines here for each of the conditions that we check; and split the ternary into an if statement such that it's clearer that we only make a change (return null) when those conditions match.

Suggested change

	J.MethodInvocation mi = super.visitMethodInvocation(method, ctx);
	return (Objects.nonNull(mi.getSelect()) && TypeUtils.isAssignableTo(JAVA_LANG_THREAD, mi.getSelect().getType()) && mi.getSimpleName().equals("destroy")) ? null : mi;
	J.MethodInvocation mi = super.visitMethodInvocation(method, ctx);
	if (Objects.nonNull(mi.getSelect())
	&& TypeUtils.isAssignableTo(JAVA_LANG_THREAD, mi.getSelect().getType())
	&& mi.getSimpleName().equals("destroy")) {
	return null;
	}
	return mi;

[timtebeek]

Suggested change

	import java.lang.*;

[satvika-eda]

Thank you for your detailed inputs. I've made the necessary changes. Please review them.

[knutwannheden]

@satvika-eda Thanks for the contribution!