Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Recipe RemovedRuntimeTraceMethods Java 17 #530

Merged
merged 4 commits into from
Aug 12, 2024
Merged

Add Recipe RemovedRuntimeTraceMethods Java 17 #530

merged 4 commits into from
Aug 12, 2024

Conversation

ranuradh
Copy link
Contributor

@ranuradh ranuradh commented Aug 12, 2024 •
edited
Loading

What's changed?

This is a simple recipe to handle :
image
needed an update to java-version-17.yml

What's your motivation?

Needed for a Java Migration rule.

Have you considered any alternatives or workarounds?

Attaching the
rewrite.patch

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@ranuradh ranuradh added the recipe Recipe requested label Aug 12, 2024
@ranuradh ranuradh self-assigned this Aug 12, 2024
timtebeek
timtebeek approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick work!

@timtebeek timtebeek merged commit 217cf89 into openrewrite:main Aug 12, 2024
1 check passed
@ranuradh ranuradh deleted the RemovedRuntimeTraceMethods branch August 12, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timtebeek timtebeek timtebeek approved these changes

Assignees

@ranuradh ranuradh

Labels
recipe Recipe requested
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ranuradh @timtebeek @AnuRam123