Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unnecessary trailing escape in UseTextBlocks #558

Conversation

BramliAK
Copy link
Contributor

What's changed?

i added some control to not create unnecessary trailing escape in some cases on the other hand I leave them in the case where the text ends with Quotation Mark, Equal, Curly Brackets and Semicolon because I saw that it is more readable like that

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@timtebeek
Copy link
Contributor

Really appreciate the measured change here @BramliAK !

@timtebeek timtebeek linked an issue Sep 18, 2024 that may be closed by this pull request
@timtebeek timtebeek changed the title Issue 555 use text blocks creating unnecessary trailing escape Drop unnecessary trailing escape in UseTextBlocks Sep 18, 2024
@timtebeek timtebeek added bug Something isn't working enhancement New feature or request labels Sep 18, 2024
@timtebeek timtebeek merged commit 37ac5f9 into openrewrite:main Sep 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

UseTextBlocks creating unnecessary trailing escape
2 participants