Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress indicator appears in wrong place if vertical height exceeds window height #1269

Closed
danyill opened this issue Jun 22, 2023 · 3 comments · Fixed by #1276 or #1543
Closed

Progress indicator appears in wrong place if vertical height exceeds window height #1269

danyill opened this issue Jun 22, 2023 · 3 comments · Fixed by #1276 or #1543
Assignees
Labels
Kind: Bug Something isn't working

Comments

@danyill
Copy link
Collaborator

danyill commented Jun 22, 2023

Describe the bug

When I moved the progress indicator to the top bar, it never occurred to me (alas) that we would hide this on overflow, which means it is possible to have the progress indicator appear within the canvas as shown in the screenshot below.

To Reproduce

  1. Open the clean up plugin with enough items that you need to scroll down.
  2. Remove some item.
  3. Watch the progress indicator turn up in the wrong place.

Expected behavior

The progress indicator should move to the top underneath the top navigation bar.

Screenshots

image

Desktop (please complete the following information):

  • OS: Windows
  • Browser Chrome
  • Version: 114.0.5735.110 (Official Build) (64-bit)
@danyill danyill added the Kind: Bug Something isn't working label Jun 22, 2023
@ca-d
Copy link
Contributor

ca-d commented Jun 23, 2023

Why not just move the progress indicator atop the tab bar (aligned with the very bottom of the the top app bar) in general?

@danyill
Copy link
Collaborator Author

danyill commented Jun 23, 2023

Why not just move the progress indicator atop the tab bar (aligned with the very bottom of the the top app bar) in general?

Good idea, let me do a PR with that approach. Thanks for taking a look.

@danyill
Copy link
Collaborator Author

danyill commented Jun 24, 2023

Why not just move the progress indicator atop the tab bar (aligned with the very bottom of the the top app bar) in general?

Hmmm, I find it a little distracting because it's placed between visually continuous parts.

What about Github styles?

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kind: Bug Something isn't working
Projects
None yet
2 participants