Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy code from core's Plugging mixin into packages/open-scd/open-scd.ts #1418

Closed
6 tasks
juancho0202 opened this issue Jan 16, 2024 · 0 comments · Fixed by #1486
Closed
6 tasks

Copy code from core's Plugging mixin into packages/open-scd/open-scd.ts #1418

juancho0202 opened this issue Jan 16, 2024 · 0 comments · Fixed by #1486
Assignees
Labels

Comments

@juancho0202
Copy link
Contributor

juancho0202 commented Jan 16, 2024

As an OpenSCD developer I would like to be able to use the plugging loading functionality present in the Plugging mixin from OpenSCD Core.

Tasks:

  • Copying code from Pluggin mixin in core into open-scd.ts
  • Alter the code to include an attribute that indicates if a menu plugin is "top", "middle" or "bottom"
  • Create a foundation file to host the Plugin interface code
  • Remove Plugging mixin in core
  • Add tests where a plugin is passed down as an object in the "plugins" prop and it's loaded in open-scd
  • Add tests for all menu plugin positions and make sure they are rendered in the correct place

Acceptance Criteria:

  1. It doesn't break current functionality and loads existing plugins successfully
  2. User is able to add plugins by passing down a plugins object to the open-scd tag
@juancho0202 juancho0202 added the Kind: Enhancement New Request label Jan 16, 2024
@juancho0202 juancho0202 added the Status: Ready for development Checked by all co-developers label Feb 6, 2024
@juancho0202 juancho0202 removed the Status: Ready for development Checked by all co-developers label Mar 4, 2024
@juancho0202 juancho0202 changed the title Using both Plugging mixins from OpenSCD and OpenSCD core side-by-side Include code from Plugging mixin in openscd/open-scd/core into openscd/open-scd/open-scd.ts Mar 6, 2024
@juancho0202 juancho0202 changed the title Include code from Plugging mixin in openscd/open-scd/core into openscd/open-scd/open-scd.ts Include code from Plugging mixin in core into packages/open-scd/open-scd.ts Mar 6, 2024
@juancho0202 juancho0202 changed the title Include code from Plugging mixin in core into packages/open-scd/open-scd.ts Copy code from core's Plugging mixin into packages/open-scd/open-scd.ts Mar 19, 2024
juancho0202 added a commit that referenced this issue Apr 10, 2024
Signed-off-by: Juan Munoz <juancho0202@gmail.com>
juancho0202 added a commit that referenced this issue May 7, 2024
…1486)

* feat: allow open-scd to have plugins being passed down as props

Signed-off-by: Juan Munoz <juancho0202@gmail.com>

* test: added integration snapshot test for plugins prop

Signed-off-by: Juan Munoz <juancho0202@gmail.com>

* chore: refactor to implement "tasks" section on issue #1418

Signed-off-by: Juan Munoz <juancho0202@gmail.com>

* chore: remove unnecessary default attribute from core's Plugin interface

Signed-off-by: Juan Munoz <juancho0202@gmail.com>

* chore: change position attr to accomodate for editor plug-in positions

Signed-off-by: Juan Munoz <juancho0202@gmail.com>

* chore: fixing prop "default" to "active" and adding snapshot test with an editor plugin

Signed-off-by: Juan Munoz <juancho0202@gmail.com>

* chore: fixing casting of CorePlugin type into Plugin type

Signed-off-by: Juan Munoz <juancho0202@gmail.com>

* chore: updating with snapshots from main

Signed-off-by: Juan Munoz <juancho0202@gmail.com>

---------

Signed-off-by: Juan Munoz <juancho0202@gmail.com>
Co-authored-by: Steffen van den Driest <35229971+Stef3st@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
2 participants