Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(editors/subscription): Increase timeout for failing subscriber/fcda-binding-list test #1274

Merged
merged 1 commit into from
Jun 26, 2023
Merged

fix(editors/subscription): Increase timeout for failing subscriber/fcda-binding-list test #1274

merged 1 commit into from
Jun 26, 2023

Conversation

danyill
Copy link
Collaborator

@danyill danyill commented Jun 23, 2023

Closes #1257

Just a timeout increase, I have looked for a better option and not found one.

@danyill danyill marked this pull request as ready for review June 23, 2023 06:48
@danyill danyill requested a review from Stef3st June 23, 2023 06:48
Stef3st
Stef3st approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@Stef3st Stef3st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, if tests are going too fast I dont see any harm in increasing the time

@danyill danyill merged commit 8c620eb into openscd:main Jun 26, 2023
@github-actions github-actions bot mentioned this pull request Mar 19, 2024
Closed
@github-actions github-actions bot mentioned this pull request Jun 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stef3st Stef3st Stef3st approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fcda-binding-list test fails
2 participants
@danyill @Stef3st