Add name filters (SOFTWARE-5442) #2911
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added ability to filter based on the name of a facility, support center, resourcegroup, site, vo, voown, and service Did a little refactoring of the Filter class Added tests for the above
|
I can delete the parts that add the ability to filter by name for this other the rg if they aren't need. Just made sense to do them all at once. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to filter based on the name of a facility, support center, resourcegroup, site, vo, voown, and service
Did a little refactoring of the Filter class
Added tests for the above
Implementation wise I decided to only accept name filters using the rg_name[] ( {other}_name[] ) key and I reimplemented the id selection to also accept rg_id[] alongside the previous selection scheme.