Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ticket opening from topology #401

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

djw8605
Copy link
Member

@djw8605 djw8605 commented Jan 31, 2019

Still need to be completed:

This adds 2 new configuration values:

  • GOOGLE_CAPTCHA_KEY: Registered CAPTCHA secret key.
  • FRESHDESK_API_KEY: API key for FreshDesk. I believe each person has their own API key, and I don't know how to make it general for the entire project.

This includes the public key for the google captcha, which should
work for opensciencegrid.org domain.
@djw8605 djw8605 added enhancement New feature or request and removed do-not-merge labels Feb 1, 2019
@djw8605
Copy link
Member Author

djw8605 commented Feb 1, 2019

Read for review.

src/app.py Outdated Show resolved Hide resolved
@bbockelm
Copy link
Contributor

bbockelm commented Feb 5, 2019

@djw8605 - can you attach some screenshots to the ticket so we can see what the UI looks like?

Also - I don't want to deploy any ticket UI that might ask for an X509 certificate. Can we limit this to a specific vhost?

@brianhlin
Copy link
Member

@djw8605 - can you attach some screenshots to the ticket so we can see what the UI looks like?

Or better yet, deployment to the ITB?

@djw8605
Copy link
Member Author

djw8605 commented Feb 12, 2019

Multiple resources select with smart search.
image

It will add all of the "Admin" contacts for those resources.

@brianhlin
Copy link
Member

Do we have a drop-down for VOs in case sites are having issues with a specific VO's?

@djw8605
Copy link
Member Author

djw8605 commented Feb 15, 2019

Nope, for now, this was specific to opening ticket against sites.

Copy link
Member

@brianhlin brianhlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also have a short description at the top of the ticket explaining who this form is for and why they should use it.

src/templates/ticket.html.j2 Outdated Show resolved Hide resolved
src/templates/ticket.html.j2 Outdated Show resolved Hide resolved
@djw8605
Copy link
Member Author

djw8605 commented Feb 19, 2019

Added a few sentences at the top:
image

@brianhlin
Copy link
Member

That looks good. I forgot to ask, can we enable the Freshdesk "support" widget on this page, too?

@djw8605
Copy link
Member Author

djw8605 commented Feb 19, 2019

the freshdesk support widget is enabled. You can see it in the screenshot on the right.

@brianhlin
Copy link
Member

Oops, so it is. Could we get a link added to the main page under "Human-readable pages"?

Between the freshdesk widget, ticket jquery... too much
js to have it on/off toggle for each page.
@brianhlin
Copy link
Member

Let's hold off on merging this until we clear up the issues mentioned here: https://support.opensciencegrid.org/a/tickets/8380

@djw8605
Copy link
Member Author

djw8605 commented Feb 28, 2019

The issues mentioned in that ticket are related to public ticket, not necessarily with this ticket creation. I see them as unrelated.


if url_request.status_code in [ 200, 201 ]:
json_return = url_request.json()
return_str = "Created Ticket {}".format(json_return['id'])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should tell users that they'll receive an email shortly. Would it be possible to have this show up as a message on the form page? The page with the return_str is a little bare.

@brianhlin brianhlin self-assigned this Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants