-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ticket opening from topology #401
base: master
Are you sure you want to change the base?
Conversation
This includes the public key for the google captcha, which should work for opensciencegrid.org domain.
Read for review. |
@djw8605 - can you attach some screenshots to the ticket so we can see what the UI looks like? Also - I don't want to deploy any ticket UI that might ask for an X509 certificate. Can we limit this to a specific vhost? |
Or better yet, deployment to the ITB? |
Do we have a drop-down for VOs in case sites are having issues with a specific VO's? |
Nope, for now, this was specific to opening ticket against sites. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also have a short description at the top of the ticket explaining who this form is for and why they should use it.
That looks good. I forgot to ask, can we enable the Freshdesk "support" widget on this page, too? |
the freshdesk support widget is enabled. You can see it in the screenshot on the right. |
Oops, so it is. Could we get a link added to the main page under "Human-readable pages"? |
Between the freshdesk widget, ticket jquery... too much js to have it on/off toggle for each page.
Let's hold off on merging this until we clear up the issues mentioned here: https://support.opensciencegrid.org/a/tickets/8380 |
The issues mentioned in that ticket are related to public ticket, not necessarily with this ticket creation. I see them as unrelated. |
|
||
if url_request.status_code in [ 200, 201 ]: | ||
json_return = url_request.json() | ||
return_str = "Created Ticket {}".format(json_return['id']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should tell users that they'll receive an email shortly. Would it be possible to have this show up as a message on the form page? The page with the return_str is a little bare.
Still need to be completed:
This adds 2 new configuration values:
GOOGLE_CAPTCHA_KEY
: Registered CAPTCHA secret key.FRESHDESK_API_KEY
: API key for FreshDesk. I believe each person has their own API key, and I don't know how to make it general for the entire project.