Loop

[sadrasabouri]

Reference Issues/PRs

#6

What does this implement/fix? Explain your changes.

Changed

• loop parameter added to play function

Any other comments?

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 89.13043% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 95.80%. Comparing base (ce1b94d) to head (33d1f5c).

Files	Patch %	Lines
nava/thread.py	85.00%	2 Missing and 1 partial ⚠️
nava/functions.py	92.00%	0 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev      #31      +/-   ##
==========================================
- Coverage   99.19%   95.80%   -3.39%     
==========================================
  Files           4        4              
  Lines         124      143      +19     
  Branches       12       18       +6     
==========================================
+ Hits          123      137      +14     
- Misses          0        2       +2     
- Partials        1        4       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sepandhaghighi]

@sadrasabouri Thanks for your efforts 💯

This implementation cannot be stopped in async mode. One of the best solutions is to handle the loop in NavaThread
I suggest that you consider adding this particular feature in a future release that comes after version 0.3.

[sadrasabouri]

@sepandhaghighi I added the loop flag to NavaThread.__init__. I think that's the better option comparing to setter/getter approach.

[sepandhaghighi]

@sadrasabouri Could you please test this version on different operating systems? Once confirmed, we can proceed with the final review and merge.

[sadrasabouri]

Local tests on OSs

• MacOS Sonoma 14.2.1
• Windows 10
• Ubuntu 16.04
• Ubuntu 22.04

[sepandhaghighi]

🚀