Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: better label management #175

Closed
slundi opened this issue Mar 7, 2024 · 7 comments
Closed

Feature request: better label management #175

slundi opened this issue Mar 7, 2024 · 7 comments
Labels
fix-committed Fix for the issue is in the main branch

Comments

@slundi
Copy link

slundi commented Mar 7, 2024

Hi

Is it possible to have those UI improvements:

  • specify label(s) while adding torrent
  • when setting label on a torrent, the select is hiding the Save and Cancel buttons
  • with a right click, in the menu: can we have the existing label list to apply them on torrents
  • always keep some labels (movie, tv, anime, game, ...) because when no torrent have the label it disappears

Regards

@qu1ck
Copy link
Member

qu1ck commented Mar 7, 2024

specify label(s) while adding torrent

It is supported. Update your transmission server to v4

when setting label on a torrent, the select is hiding the Save and Cancel buttons

Yes. Do you have a better suggestion? The multiselect ui element with ability to add free form text is the only one that fits the requirements here. Only thing I can think of that can replace it is a much more complex multi checkbox list + a separate add button which is worse in my opinion than just a click to hide the dropdown.

with a right click, in the menu: can we have the existing label list to apply them on torrents

No, such UI would give a false impression that labels can be added/removed without affecting existing labels of torrents but that is not how transmission's api works.

always keep some labels (movie, tv, anime, game, ...) because when no torrent have the label it disappears

This can be added

@jpovixwm
Copy link
Contributor

jpovixwm commented Mar 8, 2024

No, such UI would give a false impression that labels can be added/removed without affecting existing labels of torrents but that is not how transmission's api works.

I think this could work if it was restricted to single row selection. Make it a submenu with all the currently-applied labels with checkmarks to the left of each item, together with known and not-yet-applied labels without checkmarks. This would make it possible to quickly apply or remove a label from a single torrent.
However, having the context menu stay open after toggling a label, to enable the quick toggling of more than one label, could be a bit tricky because then it would probably need to be debounced somehow if the user toggles a couple of labels in quick succession, which opens another can of worms😕

@qu1ck
Copy link
Member

qu1ck commented Mar 8, 2024

Its a lot of worms on slow connections and out of order responses. Some of them can be avoided if the "commit" only happens after the menu is closed but it's not worth the trouble imo.

@slundi
Copy link
Author

slundi commented Mar 8, 2024

Thanks @qu1ck for your answers.

Transmission v4 is not available in the packages yet (Linux Mint) 😞
So I'll have to install it manually.

when setting label on a torrent, the select is hiding the Save and Cancel buttons

Moving the buttons to the top? Increase height of the dialog (to display maybe 5 lines) with empty space

always keep some labels (movie, tv, anime, game, ...) because when no torrent have the label it disappears

This can be added

Great! With icons to be fancy?

@qu1ck
Copy link
Member

qu1ck commented Mar 8, 2024

So I'll have to install it manually.

Docker image is best if you want fast updates without the hassle of compiling yourself.

Moving the buttons to the top? Increase height of the dialog (to display maybe 5 lines) with empty space

I will play with this idea and see how it looks in practice

With icons to be fancy?

No icons, it will be user configurable and empty by default because everyone uses different labels and even in different languages.

@jfeilbach
Copy link

qu1ck added a commit that referenced this issue Mar 18, 2024
qu1ck added a commit that referenced this issue Apr 1, 2024
These labels always are shown in filters panel and in suggestions
for torrents, regardless if they are present on the server.

Issue #175
@qu1ck qu1ck added the fix-committed Fix for the issue is in the main branch label Apr 1, 2024
@qu1ck
Copy link
Member

qu1ck commented Apr 15, 2024

Implemented in v1.3.0

@qu1ck qu1ck closed this as completed Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix-committed Fix for the issue is in the main branch
Projects
None yet
Development

No branches or pull requests

4 participants