Improve files table UX (fixes #121): #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uh oh, looks like the "Open" and "Open folder" actions are broken for single-file torrents too. I'll investigate tomorrow. |
- Add visual indication to deselected directories with selected subrows - Automatically deselect directories whenever their children are deselected - Automatically select directories as soon as all of their children are selected - Change Ctrl-A behavior so that it only selects entries that match the entered search terms - Deselect entries that become hidden while using the search bar
qu1ck
reviewed
Dec 19, 2023
| @@ -183,26 +188,49 @@ function useSelected(props: FileTreeTableProps) { | |||
| return next; | |||
| }, []); | |||
|
|
|||
| const deriveNewSelection = useRef((_: boolean) => [] as string[]); | |||
There was a problem hiding this comment.
Does this have to be a ref and not a simple callback?
There was a problem hiding this comment.
If I make it a callback, there's this small quirk:
I.e. after performing an action on a directory while some of its children are filtered out, the directory becomes deselected. (because the callback is changing in this case, and eslint requires us to include the callback in useEffect's dependency array).
If it's a ref, like in the PR, this issue doesn't occur:
|
Thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fair warning: this makes the issue with not being able to perform the context menu actions "Open" and "Open folder", when multiple entries are selected, just a tiny bit worse for single-file directories, because when you right click the file, the directory gets automatically selected.
When it comes to my opinion on how to fix that, I think it'd be OK to make these context menu entries apply only to the row that was actually right-clicked.