Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/condensed folders tree #139

Merged
merged 13 commits into from
Jan 11, 2024
Merged
Show file tree
Hide file tree
Changes from 10 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 63 additions & 5 deletions src/components/filters.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ const DefaultRoot: Directory = {
level: -1,
};

function buildDirTree(paths: string[], expanded: string[]): Directory {
function buildDirTree(paths: string[], expanded: string[], compactFolders: boolean): Directory {
const root: Directory = { ...DefaultRoot, subdirs: new Map() };

paths.forEach((path) => {
Expand All @@ -258,7 +258,50 @@ function buildDirTree(paths: string[], expanded: string[]): Directory {
}
});

return root;
return compactFolders ? compactFoldersTree(root) : root;
}

function compactFoldersTree(root: Directory): Directory {
/*
const squashSingleChildFolders = (root: Directory) => {
let result = root;

if (root.subdirs.size === 1) {
const [child] = root.subdirs.values();
if (root.count === child.count) {
child.name = root.name + "/" + child.name;
child.level = root.level;
result = squashSingleChildFolders(child);
}
}

return result;
}; */

const result = squashSingleChildFolders(root);

for (const [key, dir] of result.subdirs) {
dir.level = result.level + 1;
const condensedDir = compactFoldersTree(dir);
result.subdirs.set(key, condensedDir);
}

return result;
}

function squashSingleChildFolders(root: Directory): Directory {
let result = root;

if (root.subdirs.size === 1) {
const [child] = root.subdirs.values();
if (root.count === child.count) {
child.name = root.name + "/" + child.name;
child.level = root.level;
result = squashSingleChildFolders(child);
}
}

return result;
}

function flattenTree(root: Directory): Directory[] {
Expand Down Expand Up @@ -297,9 +340,9 @@ export const Filters = React.memo(function Filters({ torrents, currentFilters, s
[torrents]);

const dirs = useMemo<Directory[]>(() => {
const tree = buildDirTree(paths, serverConfig.expandedDirFilters);
const tree = buildDirTree(paths, serverConfig.expandedDirFilters, config.values.interface.compactFolders);
return flattenTree(tree);
}, [paths, serverConfig.expandedDirFilters]);
}, [paths, serverConfig.expandedDirFilters, config.values.interface.compactFolders]);

const [labels, trackers] = useMemo(() => {
const labels: Record<string, number> = {};
Expand All @@ -325,12 +368,14 @@ export const Filters = React.memo(function Filters({ torrents, currentFilters, s
}, config.values.interface.filterSections);
const [sectionsMap, setSectionsMap] = useState(getSectionsMap(sections));
const [statusFiltersVisibility, setStatusFiltersVisibility] = useState(config.values.interface.statusFiltersVisibility);
const [compactFolders, setCompactFolders] = useState(config.values.interface.compactFolders);

useEffect(() => {
config.values.interface.filterSections = sections;
config.values.interface.statusFiltersVisibility = statusFiltersVisibility;
config.values.interface.compactFolders = compactFolders;
setSectionsMap(getSectionsMap(sections));
}, [config, sections, statusFiltersVisibility]);
}, [config, sections, statusFiltersVisibility, compactFolders]);

const [info, setInfo, handler] = useContextMenu();

Expand Down Expand Up @@ -365,6 +410,11 @@ export const Filters = React.memo(function Filters({ torrents, currentFilters, s
}
}, [statusFiltersVisibility, currentFilters, setCurrentFilters]);

const onCompactFoldersClick = useCallback((e: React.MouseEvent) => {
e.stopPropagation();
setCompactFolders(!compactFolders);
}, [compactFolders]);

return (<>
<Menu
openDelay={100}
Expand Down Expand Up @@ -441,6 +491,14 @@ export const Filters = React.memo(function Filters({ torrents, currentFilters, s
>
Status filters
</Menu.Item>
<Menu.Divider/>
<Menu.Item
icon={compactFolders ? <Icon.Check size="1rem" /> : <Box miw="1rem" />}
onMouseEnter={closeStatusFiltersSubmenu}
onMouseDown={onCompactFoldersClick}
>
Compact Folders
Dukobpa3 marked this conversation as resolved.
Show resolved Hide resolved
</Menu.Item>
</MemoSectionsContextMenu>
{sections[sectionsMap.Status].visible && <div style={{ order: sectionsMap.Status }}>
<Divider mx="sm" label="Status" labelPosition="center" />
Expand Down
2 changes: 2 additions & 0 deletions src/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ interface Settings {
sashSizes: Record<SashName, [number, number]>,
filterSections: SectionsVisibility<FilterSectionName>,
statusFiltersVisibility: StatusFiltersVisibility,
compactFolders: boolean,
statusBarSections: SectionsVisibility<StatusbarSectionName>,
showFiltersPanel: boolean,
showDetailsPanel: boolean,
Expand Down Expand Up @@ -242,6 +243,7 @@ const DefaultSettings: Settings = {
!["Running", "Magnetizing"].includes(filterName),
]),
) as Record<StatusFilterName, boolean>,
compactFolders: false,
statusBarSections: StatusbarSections.map((section) => ({
section,
visible: true,
Expand Down