Skip to content

Commit

Permalink
Rename wizard to visBuilder in i18n id and formatted message id (#2635)…
Browse files Browse the repository at this point in the history
… (#2744)

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
(cherry picked from commit 8d5e504)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
  • Loading branch information
1 parent 54d8220 commit 6803242
Show file tree
Hide file tree
Showing 10 changed files with 23 additions and 23 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export const DataSourceSelect = () => {
dispatch(setIndexPattern(foundOption.id));
}
}}
prepend={i18n.translate('wizard.nav.dataSource.selector.title', {
prepend={i18n.translate('visBuilder.nav.dataSource.selector.title', {
defaultMessage: 'Data Source',
})}
error={error}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export interface Props {
* Additionally there's a button displayed that allows the user to show/hide more filter fields
*/
export function FieldSearch({ value }: Props) {
const searchPlaceholder = i18n.translate('wizard.fieldChooser.searchPlaceHolder', {
const searchPlaceholder = i18n.translate('visBuilder.fieldChooser.searchPlaceHolder', {
defaultMessage: 'Search field names',
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@ export const InfoComponent = () => {
className="hide-for-sharing"
data-test-subj="experimentalVisInfo"
size="s"
title={i18n.translate('wizard.experimentalInfoTitle', {
title={i18n.translate('visBuilder.experimentalInfoTitle', {
defaultMessage: 'This editor is experimental and should not be used in production',
})}
iconType="beaker"
>
<FormattedMessage
id="wizard.experimentalInfoText"
id="visBuilder.experimentalInfoText"
defaultMessage="We want to hear from you about how we can improve your experience. Leave feedback in {githubLink}."
values={{
githubLink: (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,13 +53,13 @@ export const RightNav = () => {
</div>
{newVisType && (
<EuiConfirmModal
title={i18n.translate('wizard.rightNav.changeVisType.modalTitle', {
title={i18n.translate('visBuilder.rightNav.changeVisType.modalTitle', {
defaultMessage: 'Change visualization type',
})}
confirmButtonText={i18n.translate('wizard.rightNav.changeVisType.confirmText', {
confirmButtonText={i18n.translate('visBuilder.rightNav.changeVisType.confirmText', {
defaultMessage: 'Change type',
})}
cancelButtonText={i18n.translate('wizard.rightNav.changeVisType.cancelText', {
cancelButtonText={i18n.translate('visBuilder.rightNav.changeVisType.cancelText', {
defaultMessage: 'Cancel',
})}
onCancel={() => setNewVisType(undefined)}
Expand All @@ -78,7 +78,7 @@ export const RightNav = () => {
>
<p>
<FormattedMessage
id="wizard.rightNav.changeVisType.modalDescription"
id="visBuilder.rightNav.changeVisType.modalDescription"
defaultMessage="Changing the visualization type will reset all field selections. Do you want to continue?"
/>
</p>
Expand Down
6 changes: 3 additions & 3 deletions src/plugins/wizard/public/application/utils/breadcrumbs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@
import { i18n } from '@osd/i18n';
import { VISUALIZE_ID } from '../../../common';

const defaultEditText = i18n.translate('wizard.editor.defaultEditBreadcrumbText', {
const defaultEditText = i18n.translate('visBuilder.editor.defaultEditBreadcrumbText', {
defaultMessage: 'Edit',
});

export function getVisualizeLandingBreadcrumbs(navigateToApp) {
return [
{
text: i18n.translate('wizard.listing.breadcrumb', {
text: i18n.translate('visBuilder.listing.breadcrumb', {
defaultMessage: 'Visualize',
}),
onClick: () => navigateToApp(VISUALIZE_ID),
Expand All @@ -25,7 +25,7 @@ export function getCreateBreadcrumbs(navigateToApp) {
return [
...getVisualizeLandingBreadcrumbs(navigateToApp),
{
text: i18n.translate('wizard.editor.createBreadcrumb', {
text: i18n.translate('visBuilder.editor.createBreadcrumb', {
defaultMessage: 'Create',
}),
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,16 +69,16 @@ export const getTopNavConfig = (
id: 'save',
iconType: savedWizardVis?.id && originatingApp ? undefined : ('save' as const),
emphasize: savedWizardVis && !savedWizardVis.id,
description: i18n.translate('wizard.topNavMenu.saveVisualizationButtonAriaLabel', {
description: i18n.translate('visBuilder.topNavMenu.saveVisualizationButtonAriaLabel', {
defaultMessage: 'Save Visualization',
}),
className: savedWizardVis?.id && originatingApp ? 'saveAsButton' : '',
label:
savedWizardVis?.id && originatingApp
? i18n.translate('wizard.topNavMenu.saveVisualizationAsButtonLabel', {
? i18n.translate('visBuilder.topNavMenu.saveVisualizationAsButtonLabel', {
defaultMessage: 'save as',
})
: i18n.translate('wizard.topNavMenu.saveVisualizationButtonLabel', {
: i18n.translate('visBuilder.topNavMenu.saveVisualizationButtonLabel', {
defaultMessage: 'save',
}),
testId: 'wizardSaveButton',
Expand Down Expand Up @@ -115,7 +115,7 @@ export const getTopNavConfig = (
emphasize: true,
iconType: 'checkInCircleFilled' as const,
description: i18n.translate(
'wizard.topNavMenu.saveAndReturnVisualizationButtonAriaLabel',
'visBuilder.topNavMenu.saveAndReturnVisualizationButtonAriaLabel',
{
defaultMessage: 'Finish editing wizard and return to the last app',
}
Expand Down Expand Up @@ -193,7 +193,7 @@ export const getOnSave = (

if (id) {
toastNotifications.addSuccess({
title: i18n.translate('wizard.topNavMenu.saveVisualization.successNotificationText', {
title: i18n.translate('visBuilder.topNavMenu.saveVisualization.successNotificationText', {
defaultMessage: `Saved '{visTitle}'`,
values: {
visTitle: savedWizardVis.title,
Expand Down Expand Up @@ -236,7 +236,7 @@ export const getOnSave = (
console.error(error);

toastNotifications.addDanger({
title: i18n.translate('wizard.topNavMenu.saveVisualization.failureNotificationText', {
title: i18n.translate('visBuilder.topNavMenu.saveVisualization.failureNotificationText', {
defaultMessage: `Error on saving '{visTitle}'`,
values: {
visTitle: newTitle,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export const useCanSave = () => {
// TODO: Need to finalize the error messages
const getErrorMsg = (isEmpty, hasNoChange, hasDraftAgg) => {
const i18nTranslate = (key: string, defaultMessage: string) =>
i18n.translate(`wizard.saveVisualizationTooltip.${key}`, {
i18n.translate(`visBuilder.saveVisualizationTooltip.${key}`, {
defaultMessage,
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,14 @@ export function DisabledVisualization({ title }: { title: string }) {
<EuiIcon type="beaker" size="xl" />
<div>
<FormattedMessage
id="wizard.disabledVisualizationTitle"
id="visBuilder.disabledVisualizationTitle"
defaultMessage="{title} is an experimental visualization."
values={{ title: <em className="visDisabledLabVisualization__title">{title}</em> }}
/>
</div>
<div>
<FormattedMessage
id="wizard.disabledVisualizationMessage"
id="visBuilder.disabledVisualizationMessage"
defaultMessage="Please turn on lab-mode in the advanced settings to see these visualizations."
/>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ export class WizardEmbeddableFactoryDefinition
}

public getDisplayName() {
return i18n.translate('wizard.displayName', {
return i18n.translate('visBuilder.displayName', {
defaultMessage: PLUGIN_ID,
});
}
Expand Down
4 changes: 2 additions & 2 deletions src/plugins/wizard/public/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,8 @@ export class WizardPlugin
visualizations.registerAlias({
name: PLUGIN_ID,
title: PLUGIN_NAME,
description: i18n.translate('wizard.visPicker.description', {
defaultMessage: 'Create visualizations using the new Drag & Drop experience',
description: i18n.translate('visBuilder.visPicker.description', {
defaultMessage: 'Create visualizations using the new Visualization Builder',
}),
icon: wizardIconSecondaryFill,
stage: 'experimental',
Expand Down

0 comments on commit 6803242

Please sign in to comment.