Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Remove 'Basic license' reference in DQL helper popover #388

Closed
kgcreative opened this issue May 28, 2021 · 0 comments · Fixed by #391
Closed

[BUG] Remove 'Basic license' reference in DQL helper popover #388

kgcreative opened this issue May 28, 2021 · 0 comments · Fixed by #391
Labels
bug Something isn't working

Comments

@kgcreative
Copy link
Member

Describe the bug

The DQL helper popover references a 'Basic license' in the description.

Screen Shot of incorrect popover text

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Discover'
  2. Click on 'DQL' to the right of the "Query" input.
  3. See popover description text: The OpenSearch Dashboards Query Language (DQL) offers a simplified query syntax and support for scripted fields. DQL also provides autocomplete if you have a Basic license or above. If you turn off DQL, OpenSearch Dashboards uses Lucene.

Expected behavior
The description text should not reference the Basic license requirement. The OpenSearch Dashboards Query Language (DQL) offers a simplified query syntax and support for scripted fields. If you turn off DQL, OpenSearch Dashboards uses Lucene.

OpenSearch Version
1.0

Dashboards Version
1.0

Plugins

Please list all plugins currently enabled.

Screenshots

If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: MacOS
  • Browser and version [e.g. 22]: Chrome - 90.0.4430.212 (Official Build) (x86_64)

Additional context

Add any other context about the problem here.
@kgcreative kgcreative added Beta bug Something isn't working untriaged labels May 28, 2021
@kgcreative kgcreative changed the title [BUG] [BUG] Remove 'Basic license' reference in DQL helper popover May 28, 2021
@kavilla kavilla removed the untriaged label May 29, 2021
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue May 30, 2021
@kavilla
[Purify] remove upsells and branding from pre-fork
cfa4523 
Left-over upsells and branding that were missed in previous
updates since they are not easy to catch.

Issues:
opensearch-project#388
opensearch-project#384

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla kavilla mentioned this issue May 30, 2021
Merged
5 tasks
@kavilla kavilla linked a pull request May 30, 2021 that will close this issue
[Purify] remove upsells and branding from pre-fork #391
Merged
5 tasks
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Jun 2, 2021
@kavilla
[Purify] remove upsells and branding from pre-fork
35e9a38 
Left-over upsells and branding that were missed in previous
updates since they are not easy to catch.

Issues:
opensearch-project#359
opensearch-project#388
opensearch-project#384

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit that referenced this issue Jun 3, 2021
@kavilla
[Purify] remove upsells and branding from pre-fork (#391)
d56a532 
Left-over upsells and branding that were missed in previous
updates since they are not easy to catch.

Issues:
#359
#388
#384

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit that referenced this issue Jun 3, 2021
@kavilla
[Purify] remove upsells and branding from pre-fork (#391)
743d923 
Left-over upsells and branding that were missed in previous
updates since they are not easy to catch.

Issues:
#359
#388
#384

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit that referenced this issue Jun 3, 2021
@kavilla
[Purify] remove upsells and branding from pre-fork (#391)
f996be6 
Left-over upsells and branding that were missed in previous
updates since they are not easy to catch.

Issues:
#359
#388
#384

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Purify] remove upsells and branding from pre-fork kavilla/OpenSearch-Dashboards-1
2 participants
@kgcreative @kavilla