Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Doc] Add current plugin persistence implementation readme #3176

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 0ec0712 from #3081.

@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner January 4, 2023 23:23
@manasvinibs manasvinibs added the autocut Skip the changelog verification check on backports label Jan 5, 2023
abbyhu2000
abbyhu2000 previously approved these changes Jan 5, 2023
manasvinibs
manasvinibs previously approved these changes Jan 5, 2023
@manasvinibs manasvinibs added the v2.5.0 'Issues and PRs related to version v2.5.0' label Jan 5, 2023
@kavilla
Copy link
Member

kavilla commented Jan 6, 2023

probably need to add *.png to the workflow to skip running the tests or anything that goes into the /docs folder

https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/.github/workflows/build_and_test_workflow.yml#L15

@abbyhu2000
Copy link
Member

probably need to add *.png to the workflow to skip running the tests or anything that goes into the /docs folder

https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/.github/workflows/build_and_test_workflow.yml#L15

To skip the tests on the changes inside docs folder: #3197

* readme

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* Add readme for current plugin data persistence implementation

Added readme in root level doc folder

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* Changelog and minor fixes

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* some modifications

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Co-authored-by: Anan Zhuang <ananzh@amazon.com>
(cherry picked from commit 0ec0712)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@manasvinibs manasvinibs dismissed stale reviews from abbyhu2000 and themself via 9a5aa4a January 6, 2023 20:30
@codecov-commenter
Copy link

Codecov Report

Merging #3176 (9a5aa4a) into 2.x (62d36ff) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              2.x    #3176      +/-   ##
==========================================
+ Coverage   66.61%   66.66%   +0.05%     
==========================================
  Files        3219     3219              
  Lines       61531    61531              
  Branches     9431     9431              
==========================================
+ Hits        40986    41018      +32     
+ Misses      18303    18276      -27     
+ Partials     2242     2237       -5     
Flag Coverage Δ
Linux 66.60% <ø> (-0.01%) ⬇️
Windows 66.60% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/osd-optimizer/src/node/cache.ts 53.94% <0.00%> (+1.31%) ⬆️
src/dev/build/lib/config.ts 85.29% <0.00%> (+5.88%) ⬆️
...ges/osd-apm-config-loader/src/config.test.mocks.ts 100.00% <0.00%> (+8.69%) ⬆️
packages/osd-cross-platform/src/path.ts 85.36% <0.00%> (+34.14%) ⬆️
src/setup_node_env/harden/child_process.js 76.92% <0.00%> (+38.46%) ⬆️
src/dev/build/lib/get_build_number.ts 100.00% <0.00%> (+42.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@abbyhu2000 abbyhu2000 merged commit 535ecf4 into 2.x Jan 6, 2023
@github-actions github-actions bot deleted the backport/backport-3081-to-2.x branch January 6, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports v2.5.0 'Issues and PRs related to version v2.5.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants