Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reoder dev guide for yarn install to work #5138

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Reoder dev guide for yarn install to work #5138

merged 1 commit into from
Oct 3, 2023

Conversation

BSFishy
Copy link
Contributor

@BSFishy BSFishy commented Sep 27, 2023 •
edited
Loading

Description

In PR #5067, I introduced a change to make the yarn install instructions more consistent. However, they require OSD to be cloned and be the current working directory, which with that version of the dev guide, wasn't the case. This reorders the sections to work properly.

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@BSFishy
Reoder dev guide for yarn install to work
02ff481 
Signed-off-by: Matt Provost <provomat@amazon.com>
@manasvinibs manasvinibs added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Sep 27, 2023
@ashwin-pc ashwin-pc merged commit 9b56575 into opensearch-project:main Oct 3, 2023
7 of 23 checks passed
Leo7Deng pushed a commit to Leo7Deng/OpenSearch-Dashboards that referenced this pull request Oct 4, 2023
@BSFishy @Leo7Deng
Reoder dev guide for yarn install to work (opensearch-project#5138)
6080149 
Signed-off-by: Matt Provost <provomat@amazon.com>
Signed-off-by: Leo Deng <leo7deng@gmail.com>
@BSFishy BSFishy deleted the dev_guide/reorder branch October 5, 2023 15:48
willie-hung pushed a commit to willie-hung/OpenSearch-Dashboards that referenced this pull request Oct 5, 2023
@BSFishy @willie-hung
Reoder dev guide for yarn install to work (opensearch-project#5138)
4a9e5b0 
Signed-off-by: Matt Provost <provomat@amazon.com>
Signed-off-by: Willie Hung <willie880201044@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavilla kavilla kavilla approved these changes

@manasvinibs manasvinibs manasvinibs approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@seanneumann seanneumann Awaiting requested review from seanneumann

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@kristenTian kristenTian Awaiting requested review from kristenTian

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

Assignees
No one assigned
Labels
Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry valued-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BSFishy @kavilla @manasvinibs @ashwin-pc