Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] GeoTileGrid Aggregation on Geo Shape field #4072

Closed
5 tasks done
navneet1v opened this issue Aug 1, 2022 · 7 comments
Closed
5 tasks done

[Feature] GeoTileGrid Aggregation on Geo Shape field #4072

navneet1v opened this issue Aug 1, 2022 · 7 comments
Assignees
@navneet1v
Labels
enhancement Enhancement or improvement to existing feature or request feature New feature or request Geospatial Search:Aggregations v2.9.0 'Issues and PRs related to version v2.9.0'

Comments

@navneet1v
Copy link
Contributor

navneet1v commented Aug 1, 2022 •
edited
Loading

Description

This issue tracks the implementation of GeoTileGrid Aggregation on Geo Shape field.

Tasks:

  • Refactor code of GeoTileGrid Aggregation on GeoPoint from server to modules/geo folder.
  • Implement the GeoHashGrid on GeoShape field
    • Implement the code to find the intersection with the tiles and return the results in correct bucket.
    • Integration Tests
    • Unit Tests

Dependency

#4049

Useful Links

  1. RFC for All Aggregations on GeoShape: [RFC] - Implement Aggregations on Geo Shape Field geospatial#84
  2. Low Level Implementation Proposal: [Proposal]: Low Level Implementation Details for Geo Shape Aggregation and future Geo related Features geospatial#92
  3. Enabling Doc values for GeoShape: Enable Doc values for GeoShape Field #4049
  4. All Aggregation Implementation issue: Implement Aggregations on Geo Shape geospatial#104
  5. [RFC] - Geo Tile Grid Aggregation on Geo Shape Field geospatial#195
@navneet1v navneet1v added enhancement Enhancement or improvement to existing feature or request feature New feature or request Search:Aggregations Geospatial labels Aug 1, 2022
@navneet1v navneet1v self-assigned this Aug 1, 2022
This was referenced Aug 1, 2022
Open
Closed
navneet1v added a commit to navneet1v/OpenSearch that referenced this issue Aug 4, 2022
@navneet1v
Refactored the src and test of GeoHashGrid and GeoTileGrid Aggregatio…
7d02df1 
…ns on GeoPoint from server folder to geo module.(opensearch-project#4071) (opensearch-project#4072)

The changes also include:
   * Updated Search plugin to provide the interface so that plugins can also register the compositie aggregations
   * Added YAML test for the geo_grid, geo_tile and composite aggregation

Signed-off-by: Navneet Verma <navneev@amazon.com>
@navneet1v navneet1v mentioned this issue Aug 4, 2022
Closed
5 tasks
@navneet1v navneet1v mentioned this issue Aug 9, 2022
Merged
5 tasks
navneet1v added a commit to navneet1v/OpenSearch that referenced this issue Aug 21, 2022
@navneet1v
Refactored the src and test of GeoHashGrid and GeoTileGrid Aggregatio…
da7dbea 
…ns on GeoPoint from server folder to geo module.(opensearch-project#4071) (opensearch-project#4072)

The changes also include:
   * Updated Search plugin to provide the interface so that plugins can also register the compositie aggregations
   * Added YAML test for the geo_grid, geo_tile and composite aggregation

Signed-off-by: Navneet Verma <navneev@amazon.com>
nknize pushed a commit that referenced this issue Aug 22, 2022
@navneet1v
Refactored the src and test of GeoHashGrid and GeoTileGrid Aggregatio…
5433056 
…ns on GeoPoint from server folder to geo module.(#4071) (#4072) (#4180)

The changes also includes:
   * Updated Search plugin to provide the interface so that plugins can also register the composite aggregations
   * Added YAML test for the geo_grid, geo_tile and composite aggregation

Signed-off-by: Navneet Verma <navneev@amazon.com>
navneet1v added a commit to navneet1v/OpenSearch that referenced this issue Aug 22, 2022
@navneet1v
Refactored the src and test of GeoHashGrid and GeoTileGrid Aggregatio…
2a1fa61 
…ns on GeoPoint from server folder to geo module.(opensearch-project#4071) (opensearch-project#4072) (opensearch-project#4180)

The changes also includes:
   * Updated Search plugin to provide the interface so that plugins can also register the composite aggregations
   * Added YAML test for the geo_grid, geo_tile and composite aggregation

Signed-off-by: Navneet Verma <navneev@amazon.com>
@navneet1v navneet1v mentioned this issue Aug 22, 2022
Merged
5 tasks
nknize pushed a commit that referenced this issue Aug 30, 2022
@navneet1v
Refactored the src and test of GeoHashGrid and GeoTileGrid Aggregatio…
da76f2a 
…ns on GeoPoint from server folder to geo module.(#4071) (#4072) (#4180) (#4281)

The changes also includes:
   * Updated Search plugin to provide the interface so that plugins can also register the composite aggregations
   * Added YAML test for the geo_grid, geo_tile and composite aggregation

Signed-off-by: Navneet Verma <navneev@amazon.com>
@navneet1v navneet1v added the v2.5.0 'Issues and PRs related to version v2.5.0' label Sep 7, 2022
@navneet1v navneet1v changed the title Implementation of GeoTileGrid Aggregation on Geo Shape field GeoTileGrid Aggregation on Geo Shape field Dec 2, 2022
@navneet1v navneet1v changed the title GeoTileGrid Aggregation on Geo Shape field [Feature] GeoTileGrid Aggregation on Geo Shape field Dec 2, 2022
@navneet1v navneet1v mentioned this issue Dec 5, 2022
Open
4 tasks
@navneet1v navneet1v mentioned this issue Dec 16, 2022
Merged
6 tasks
@saratvemulapalli saratvemulapalli removed the v2.5.0 'Issues and PRs related to version v2.5.0' label Jan 6, 2023
@saratvemulapalli saratvemulapalli added the v2.6.0 'Issues and PRs related to version v2.6.0' label Jan 6, 2023
@saratvemulapalli
Copy link
Member

@navneet1v moved this issue to 2.6 as well.

@navneet1v navneet1v added v2.7.0 and removed v2.6.0 'Issues and PRs related to version v2.6.0' labels Jan 24, 2023
@anasalkouz
Copy link
Member

Hey @navneet1v, are you on track to deliver this feature on 2.7. Code freeze date is April 17, 2023.

@DarshitChanpura
Copy link
Member

Hey @navneet1v. This issue will be marked for next-release v2.8.0 on (Apr 17) as that is the code-freeze date for v2.7.0. Please let me know if otherwise.

@DarshitChanpura
Copy link
Member

Tagging it for next release: v2.8.0

@DarshitChanpura DarshitChanpura added v2.8.0 'Issues and PRs related to version v2.8.0' and removed v2.7.0 labels Apr 17, 2023
@vamshin vamshin added v2.0.0 Version 2.0.0 v2.9.0 'Issues and PRs related to version v2.9.0' and removed v2.0.0 Version 2.0.0 v2.8.0 'Issues and PRs related to version v2.8.0' labels Jun 13, 2023
@dreamer-89
Copy link
Member

@navneet1v @vamshin : Is this on track for 2.9 release. If not, can you please remove (or add v2.10.0) label.

@navneet1v
Copy link
Contributor Author

@dreamer-89 this has been pushed to 2.9

@navneet1v
Copy link
Contributor Author

Closing this issue, the changes are merged to 2.9 branch of OpenSearch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@navneet1v navneet1v

Labels
enhancement Enhancement or improvement to existing feature or request feature New feature or request Geospatial Search:Aggregations v2.9.0 'Issues and PRs related to version v2.9.0'
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@navneet1v @saratvemulapalli @anasalkouz @DarshitChanpura @vamshin @dreamer-89