Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] [Telemetry-Otel] Added support for OtlpGrpcSpanExporter exporter #10164

Merged
merged 1 commit into from
Sep 21, 2023
Merged

[Backport 2.x] [Telemetry-Otel] Added support for OtlpGrpcSpanExporter exporter #10164

merged 1 commit into from
Sep 21, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 3b9c005 from #9666.

@github-actions
[Telemetry-Otel] Added support for OtlpGrpcSpanExporter exporter (#9666)
9336d1d 
* [Telemetry-Otel] Added support for OtlpGrpcSpanExporter exporter

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Made endpoint settings configurable in Exporter Factory

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Added comments

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* precommit fix

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* OTelTelemetryPluginTests test fix

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Added test for OtlpGrpcSpanExporterProvider

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* renamed var createMethodContainsSettingsParam

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* modified endpoint comment

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Remove configurable settings and provided support for getDefault()

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Updated dependencies

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Added opentelemetry-exporter-sender-okhttp dependency

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Made opentelemetry-exporter-sender-okhttp dependency runtimeonly

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Added license files for opentelemetry-exporter-sender-okhttp

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Updated okhttp dependencies to runtime only

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

---------

Signed-off-by: Shephali Mittal <shephalm@amazon.com>
Signed-off-by: shephali mittal <shephali.mittal1995@gmail.com>
Co-authored-by: Shephali Mittal <shephalm@amazon.com>
(cherry picked from commit 3b9c005)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@reta reta added backport PRs or issues specific to backporting features or enhancments v2.11.0 Issues and PRs related to version 2.11.0 labels Sep 21, 2023
@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 9336d1d

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #10164 (9336d1d) into 2.x (ad9355f) will decrease coverage by 0.08%.
Report is 2 commits behind head on 2.x.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.x   #10164      +/-   ##
============================================
- Coverage     70.83%   70.75%   -0.08%     
+ Complexity    58250    58225      -25     
============================================
  Files          4811     4811              
  Lines        275316   275323       +7     
  Branches      40464    40466       +2     
============================================
- Hits         195033   194818     -215     
- Misses        63576    63817     +241     
+ Partials      16707    16688      -19
Files Changed Coverage Δ
...ava/org/opensearch/index/mapper/MapperService.java 74.79% <ø> (ø)
...search/telemetry/tracing/OTelResourceProvider.java 100.00% <100.00%> (ø)
...etry/tracing/exporter/OTelSpanExporterFactory.java 77.77% <100.00%> (+6.34%) ⬆️

... and 470 files with indirect coverage changes

@reta reta merged commit 8cbefb0 into 2.x Sep 21, 2023
67 checks passed
@github-actions github-actions bot deleted the backport/backport-9666-to-2.x branch September 21, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reta reta reta approved these changes

@Poojita-Raj Poojita-Raj Poojita-Raj approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@peternied peternied Awaiting requested review from peternied

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

Assignees
No one assigned
Labels
backport PRs or issues specific to backporting features or enhancments v2.11.0 Issues and PRs related to version 2.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reta @Poojita-Raj