Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the means to extract the contextual properties from HttpChannel, TcpChannel and TrasportChannel without excessive typecasting #10562

Merged
merged 2 commits into from
Oct 11, 2023

Address code review comments

1c184e2
Select commit
Loading
Failed to load commit list.
Merged

Add the means to extract the contextual properties from HttpChannel, TcpChannel and TrasportChannel without excessive typecasting #10562

Address code review comments
1c184e2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 11, 2023 in 0s

71.16% (target 70.00%)

View this Pull Request on Codecov

71.16% (target 70.00%)

Details

Codecov Report

Merging #10562 (1c184e2) into main (9bcd7ea) will increase coverage by 0.00%.
Report is 2 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##               main   #10562   +/-   ##
=========================================
  Coverage     71.16%   71.16%           
- Complexity    58399    58403    +4     
=========================================
  Files          4844     4844           
  Lines        275289   275306   +17     
  Branches      40083    40086    +3     
=========================================
+ Hits         195898   195928   +30     
+ Misses        62997    62956   -41     
- Partials      16394    16422   +28     
Files Coverage Δ
...src/main/java/org/opensearch/http/HttpChannel.java 50.00% <0.00%> (-50.00%) ⬇️
...lemetry/tracing/channels/TraceableHttpChannel.java 54.54% <0.00%> (-2.60%) ⬇️
...tracing/channels/TraceableTcpTransportChannel.java 83.87% <0.00%> (-2.80%) ⬇️
...org/opensearch/transport/TaskTransportChannel.java 80.00% <0.00%> (-5.72%) ⬇️
...main/java/org/opensearch/transport/TcpChannel.java 85.71% <0.00%> (-14.29%) ⬇️
.../org/opensearch/transport/TcpTransportChannel.java 76.66% <0.00%> (-2.65%) ⬇️
...ava/org/opensearch/transport/TransportChannel.java 40.00% <0.00%> (-4.45%) ⬇️
.../opensearch/transport/netty4/Netty4TcpChannel.java 81.13% <0.00%> (-6.63%) ⬇️
.../org/opensearch/http/netty4/Netty4HttpChannel.java 65.38% <0.00%> (-19.62%) ⬇️

... and 469 files with indirect coverage changes