Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add the means to extract the contextual properties from HttpChannel, TcpChannel and TrasportChannel without excessive typecasting #10570

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport c55e1b4 from #10562.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023

Compatibility status:

Checks if related components are compatible with change 570dac9

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

…TcpChannel and TrasportChannel without excessive typecasting (#10562)

* Add the means to extract the contextual properties from HttpChannel, TcpChannel and TrasportChannel without excessive typecasting

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Address code review comments

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

---------

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit c55e1b4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@reta reta force-pushed the backport/backport-10562-to-2.x branch from d06c58a to 570dac9 Compare October 11, 2023 18:27
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #10570 (570dac9) into 2.x (422cf06) will increase coverage by 0.09%.
Report is 1 commits behind head on 2.x.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                2.x   #10570      +/-   ##
============================================
+ Coverage     70.83%   70.93%   +0.09%     
- Complexity    58509    58563      +54     
============================================
  Files          4830     4830              
  Lines        276386   276401      +15     
  Branches      40580    40582       +2     
============================================
+ Hits         195788   196066     +278     
+ Misses        63877    63616     -261     
+ Partials      16721    16719       -2     
Files Coverage Δ
...src/main/java/org/opensearch/http/HttpChannel.java 50.00% <0.00%> (-50.00%) ⬇️
...lemetry/tracing/channels/TraceableHttpChannel.java 54.54% <0.00%> (-2.60%) ⬇️
...tracing/channels/TraceableTcpTransportChannel.java 83.87% <0.00%> (-2.80%) ⬇️
...org/opensearch/transport/TaskTransportChannel.java 80.00% <0.00%> (-5.72%) ⬇️
...main/java/org/opensearch/transport/TcpChannel.java 85.71% <0.00%> (-14.29%) ⬇️
.../org/opensearch/transport/TcpTransportChannel.java 76.66% <0.00%> (-2.65%) ⬇️
...ava/org/opensearch/transport/TransportChannel.java 50.00% <0.00%> (-5.56%) ⬇️
.../org/opensearch/http/netty4/Netty4HttpChannel.java 70.00% <0.00%> (-17.50%) ⬇️
.../opensearch/transport/netty4/Netty4TcpChannel.java 73.58% <0.00%> (-14.18%) ⬇️

... and 473 files with indirect coverage changes

@reta reta merged commit 97efcfe into 2.x Oct 11, 2023
15 of 16 checks passed
@github-actions github-actions bot deleted the backport/backport-10562-to-2.x branch October 11, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants